home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 325485563

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1526#issuecomment-325485563 https://api.github.com/repos/pydata/xarray/issues/1526 325485563 MDEyOklzc3VlQ29tbWVudDMyNTQ4NTU2Mw== 2443309 2017-08-28T21:20:40Z 2017-08-28T21:20:40Z MEMBER

This looks good to me. It would be nice to have a test for this but I'm not sure its worth the effort for what is probably a rarely seen corner case.

We do need a whats-new note and to check the flake8 box.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  252813229
Powered by Datasette · Queries took 0.622ms · About: xarray-datasette