issue_comments

Table actions

3 rows where issue = 252548859 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 3 ✖

issue 1

  • (trivial) xarray.quantile silently resolves dask arrays · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
514002753 https://github.com/pydata/xarray/issues/1524#issuecomment-514002753 https://api.github.com/repos/pydata/xarray/issues/1524 MDEyOklzc3VlQ29tbWVudDUxNDAwMjc1Mw== shoyer 1217238 2019-07-23T00:18:05Z 2019-07-23T00:18:05Z MEMBER

@shoyer does dask/dask#4677 solve those accuracy concerns?

Yes, to some degree. I'm still troubled by that the "default" algorithm (which is selected by default) has no error bounds. It seems a little backwards to me to default to a fast algorithm with unknown accuracy.

Also, it still only works on 1D arrays, which would not be terribly useful for us.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   (trivial) xarray.quantile silently resolves dask arrays 252548859
404733610 https://github.com/pydata/xarray/issues/1524#issuecomment-404733610 https://api.github.com/repos/pydata/xarray/issues/1524 MDEyOklzc3VlQ29tbWVudDQwNDczMzYxMA== shoyer 1217238 2018-07-13T05:55:14Z 2018-07-13T05:55:14Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   (trivial) xarray.quantile silently resolves dask arrays 252548859
404733398 https://github.com/pydata/xarray/issues/1524#issuecomment-404733398 https://api.github.com/repos/pydata/xarray/issues/1524 MDEyOklzc3VlQ29tbWVudDQwNDczMzM5OA== shoyer 1217238 2018-07-13T05:53:58Z 2018-07-13T05:53:58Z MEMBER

@acrosby if you're at SciPy, I'd be happy to chat about this tomorrow or over the weekend if you're staying for the sprints. This is not an immediate priority for me, but it would be straightforward to make quantile work over non-chunked dimensions by rewriting it to use apply_ufunc.

Approximate quantiles over chunked dimensions could be done by leveraging dask.array.percentile, but that algorithm has some accuracy concerns. See https://github.com/dask/dask/issues/1225 for discussion.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   (trivial) xarray.quantile silently resolves dask arrays 252548859

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);