issue_comments

Table actions

1 row where issue = 252548859 and user = 1197350 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • rabernat · 1 ✖

issue 1

  • (trivial) xarray.quantile silently resolves dask arrays · 1 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
324607199 https://github.com/pydata/xarray/issues/1524#issuecomment-324607199 https://api.github.com/repos/pydata/xarray/issues/1524 MDEyOklzc3VlQ29tbWVudDMyNDYwNzE5OQ== rabernat 1197350 2017-08-24T11:18:34Z 2017-08-24T11:18:34Z MEMBER

Dask implements percentile now http://dask.pydata.org/en/latest/array-api.html#dask.array.percentile

So perhaps our version of quantile can be refactored to accommodate actual lazy computation on dask arrays, rather than simply erroring.

In any case, I agree that automatic silent eager evaluation of dask arrays is bad.

Sent from my iPhone

On Aug 24, 2017, at 11:54 AM, crusaderky notifications@github.com wrote:

In variable.py, line 1116, you're missing a raise statement:

    if isinstance(self.data, dask_array_type):
        TypeError("quantile does not work for arrays stored as dask "
                  "arrays. Load the data via .compute() or .load() prior "
                  "to calling this method.")

Currently looking into extending dask.percentile() to support more than 1D arrays, and then use it in xarray too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   (trivial) xarray.quantile silently resolves dask arrays 252548859

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);