issue_comments: 324607199

Dask implements percentile now http://dask.pydata.org/en/latest/array-api.html#dask.array.percentile

So perhaps our version of quantile can be refactored to accommodate actual lazy computation on dask arrays, rather than simply erroring.

In any case, I agree that automatic silent eager evaluation of dask arrays is bad.

Sent from my iPhone

On Aug 24, 2017, at 11:54 AM, crusaderky notifications@github.com wrote:

In variable.py, line 1116, you're missing a raise statement:

    if isinstance(self.data, dask_array_type):
        TypeError("quantile does not work for arrays stored as dask "
                  "arrays. Load the data via .compute() or .load() prior "
                  "to calling this method.")

Currently looking into extending dask.percentile() to support more than 1D arrays, and then use it in xarray too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.