issue_comments

Table actions

5 rows where issue = 251666172 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • rolling requires pandas >= 0.18 · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
325247792 https://github.com/pydata/xarray/issues/1512#issuecomment-325247792 https://api.github.com/repos/pydata/xarray/issues/1512 MDEyOklzc3VlQ29tbWVudDMyNTI0Nzc5Mg== shoyer 1217238 2017-08-28T02:48:23Z 2017-08-28T02:48:23Z MEMBER

I'm +1 for requiring NumPy 1.11 and pandas 0.18.

Though I do not yet understand well about NDArrayOperatorsMixin, it sounds a good direction to keep a well-managed code. But it might be a kind of heavy change and is better to be another issue?

Agreed!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling requires pandas >= 0.18 251666172
325171370 https://github.com/pydata/xarray/issues/1512#issuecomment-325171370 https://api.github.com/repos/pydata/xarray/issues/1512 MDEyOklzc3VlQ29tbWVudDMyNTE3MTM3MA== fujiisoup 6815844 2017-08-27T01:32:08Z 2017-08-27T01:47:54Z MEMBER

I don't see removing functions from npcompat as particularly good justification on its own.

Yes. Agreed. The reason I propose numpy 1.11 is simply that conda recommends numpy >= 1.11 for pandas==0.18, though it also has a numpy==1.10 build. (And I don't like the special treatment in our unit tests for numpy==1.10 bug related to np.quantile.)

Though I do not yet understand well about NDArrayOperatorsMixin, it sounds a good direction to keep a well-managed code. But it might be a kind of heavy change and is better to be another issue?

I think to solve this particular issue, we can update supported oldest numpy to 1.11 (or 1.10). If we could clean up casting-related things until next release, we further update it to 1.13.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling requires pandas >= 0.18 251666172
324822729 https://github.com/pydata/xarray/issues/1512#issuecomment-324822729 https://api.github.com/repos/pydata/xarray/issues/1512 MDEyOklzc3VlQ29tbWVudDMyNDgyMjcyOQ== shoyer 1217238 2017-08-25T04:44:54Z 2017-08-25T04:44:54Z MEMBER

pandas 0.18 came out in March 2016 (about 18 months ago by the time of our next release). I would be reluctant to require anything newer than NumPy 1.11, which also came out in March 2016.

I don't see removing functions from npcompat as particularly good justification on its own. But if there is new functionality that requires a newer NumPy, then that could be a good reason to require something newer (especially if it's hard to backport).

For example, if we required NumPy 1.13, then we could make use of NDArrayOperatorsMixin and __array_ufunc__. This might be worth it for the significant clean-up of our type casting hierarchy for arithmetic (e.g., as @dopplershift reported on his pain with in his scipy presentation).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling requires pandas >= 0.18 251666172
324800620 https://github.com/pydata/xarray/issues/1512#issuecomment-324800620 https://api.github.com/repos/pydata/xarray/issues/1512 MDEyOklzc3VlQ29tbWVudDMyNDgwMDYyMA== fujiisoup 6815844 2017-08-25T01:33:47Z 2017-08-25T01:33:47Z MEMBER

OK. I will send a PR to update the minimum version support. To make our current logic work, pandas >= 0.18 is required.

How about numpy? pandas itself does not require newer numpy. I'm wondering if we can require numpy > 1.11, many logics in npcompat can be cleaned up.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling requires pandas >= 0.18 251666172
324404323 https://github.com/pydata/xarray/issues/1512#issuecomment-324404323 https://api.github.com/repos/pydata/xarray/issues/1512 MDEyOklzc3VlQ29tbWVudDMyNDQwNDMyMw== shoyer 1217238 2017-08-23T17:22:03Z 2017-08-23T17:22:03Z MEMBER

We should probably update our minimum required dependencies for the next release, both for pandas and numpy. Pandas 0.15 and numpy 1.7 are pretty old now.

Additionally, I noticed that in travis's CONDA_ENV=py27-min setup, our unit tests run with pandas == 0.20, though it might be intended to run with pandas == 0.15.

Yes, this is not intended!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling requires pandas >= 0.18 251666172

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);