issue_comments: 325171370

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1512#issuecomment-325171370 https://api.github.com/repos/pydata/xarray/issues/1512 325171370 MDEyOklzc3VlQ29tbWVudDMyNTE3MTM3MA== 6815844 2017-08-27T01:32:08Z 2017-08-27T01:47:54Z MEMBER

I don't see removing functions from npcompat as particularly good justification on its own.

Yes. Agreed. The reason I propose numpy 1.11 is simply that conda recommends numpy >= 1.11 for pandas==0.18, though it also has a numpy==1.10 build. (And I don't like the special treatment in our unit tests for numpy==1.10 bug related to np.quantile.)

Though I do not yet understand well about NDArrayOperatorsMixin, it sounds a good direction to keep a well-managed code. But it might be a kind of heavy change and is better to be another issue?

I think to solve this particular issue, we can update supported oldest numpy to 1.11 (or 1.10). If we could clean up casting-related things until next release, we further update it to 1.13.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   251666172