issue_comments

Table actions

3 rows where issue = 245778442 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Slicing inconsistent for coordinates and dimensions without coordinates · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
506913886 https://github.com/pydata/xarray/issues/1492#issuecomment-506913886 https://api.github.com/repos/pydata/xarray/issues/1492 MDEyOklzc3VlQ29tbWVudDUwNjkxMzg4Ng== stale[bot] 26384082 2019-06-29T00:58:32Z 2019-06-29T00:58:32Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Slicing inconsistent for coordinates and dimensions without coordinates 245778442
318788600 https://github.com/pydata/xarray/issues/1492#issuecomment-318788600 https://api.github.com/repos/pydata/xarray/issues/1492 MDEyOklzc3VlQ29tbWVudDMxODc4ODYwMA== shoyer 1217238 2017-07-29T00:11:49Z 2017-07-29T00:12:04Z MEMBER

To be honest, this wasn't entirely intentional: I didn't think about the difference in slice handling conventions between labeled and unlabeled arrays when we changed this in 0.9. But at this point, I would be loathe to change it.

I suppose this is also an argument in favor of changing the slice convention we copied from pandas to exclusive rather than inclusive of upper bounds.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Slicing inconsistent for coordinates and dimensions without coordinates 245778442
318774938 https://github.com/pydata/xarray/issues/1492#issuecomment-318774938 https://api.github.com/repos/pydata/xarray/issues/1492 MDEyOklzc3VlQ29tbWVudDMxODc3NDkzOA== benbovy 4160723 2017-07-28T22:17:40Z 2017-07-28T22:17:40Z MEMBER

Maybe slicing uses the standard (excluding) python slice() for these dimensions and continues to use the (including) pandas slice for coordinates?

Yes, this is what xarray does since 0.9. From the indexing section of the documentation:

Label based indexing with .sel and .loc uses standard positional, integer-based indexing as a fallback for dimensions without a coordinate label.

To fix your scripts you have to choose between set range coordinates or update the slice values. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Slicing inconsistent for coordinates and dimensions without coordinates 245778442

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);