issue_comments

Table actions

5 rows where issue = 235224055 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • time.units truncated when saving to_netcdf · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
786735133 https://github.com/pydata/xarray/issues/1449#issuecomment-786735133 https://api.github.com/repos/pydata/xarray/issues/1449 MDEyOklzc3VlQ29tbWVudDc4NjczNTEzMw== guziy 900941 2021-02-26T16:01:15Z 2021-02-26T16:46:33Z CONTRIBUTOR

Hi, I have a similar problem. We have model runs starting at 0Z and 12Z so the ones starting at 0Z don't have time (only date) in the unit string, which is not consistent... Is there a workaround?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   time.units truncated when saving to_netcdf 235224055
497130146 https://github.com/pydata/xarray/issues/1449#issuecomment-497130146 https://api.github.com/repos/pydata/xarray/issues/1449 MDEyOklzc3VlQ29tbWVudDQ5NzEzMDE0Ng== dcherian 2448579 2019-05-29T22:21:55Z 2019-05-29T22:21:55Z MEMBER

still an issue...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   time.units truncated when saving to_netcdf 235224055
497129734 https://github.com/pydata/xarray/issues/1449#issuecomment-497129734 https://api.github.com/repos/pydata/xarray/issues/1449 MDEyOklzc3VlQ29tbWVudDQ5NzEyOTczNA== stale[bot] 26384082 2019-05-29T22:20:13Z 2019-05-29T22:20:13Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   time.units truncated when saving to_netcdf 235224055
308105236 https://github.com/pydata/xarray/issues/1449#issuecomment-308105236 https://api.github.com/repos/pydata/xarray/issues/1449 MDEyOklzc3VlQ29tbWVudDMwODEwNTIzNg== mathause 10194086 2017-06-13T12:50:38Z 2017-06-13T12:50:38Z MEMBER

Well, not specifying the time would conform to the CF conventions... (http://cfconventions.org/cf-conventions/v1.6.0/cf-conventions.html#time-coordinate), so this might be an issue in panoply.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   time.units truncated when saving to_netcdf 235224055
307839267 https://github.com/pydata/xarray/issues/1449#issuecomment-307839267 https://api.github.com/repos/pydata/xarray/issues/1449 MDEyOklzc3VlQ29tbWVudDMwNzgzOTI2Nw== shoyer 1217238 2017-06-12T16:16:07Z 2017-06-12T16:16:07Z MEMBER

I didn't realize that some applications would have trouble with time-offsets without hours, but we can easily change this. The logic in controlled by these lines (called from here), as you can see use different helper functions for formatting the time-offset string -- either format_timestamp(x) or str(pd.Timestamp(x)).

Either way, you certainly have identified as inconsistency. It doesn't make sense to "clean-up" manually specified time units to add the "T" but not include that in our auto-generated time units. We should probably switch our time units to include "T" because that's ISO-8601, and I'm no longer sure why we normalize time units at all rather than just writing them unmodified.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   time.units truncated when saving to_netcdf 235224055

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);