home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 307839267

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1449#issuecomment-307839267 https://api.github.com/repos/pydata/xarray/issues/1449 307839267 MDEyOklzc3VlQ29tbWVudDMwNzgzOTI2Nw== 1217238 2017-06-12T16:16:07Z 2017-06-12T16:16:07Z MEMBER

I didn't realize that some applications would have trouble with time-offsets without hours, but we can easily change this. The logic in controlled by these lines (called from here), as you can see use different helper functions for formatting the time-offset string -- either format_timestamp(x) or str(pd.Timestamp(x)).

Either way, you certainly have identified as inconsistency. It doesn't make sense to "clean-up" manually specified time units to add the "T" but not include that in our auto-generated time units. We should probably switch our time units to include "T" because that's ISO-8601, and I'm no longer sure why we normalize time units at all rather than just writing them unmodified.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  235224055
Powered by Datasette · Queries took 0.84ms · About: xarray-datasette