issue_comments

Table actions

4 rows where issue = 225672435 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 4 ✖

issue 1

  • dl tutorial files to tmp directory, then move them once successful · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
302955973 https://github.com/pydata/xarray/pull/1393#issuecomment-302955973 https://api.github.com/repos/pydata/xarray/issues/1393 MDEyOklzc3VlQ29tbWVudDMwMjk1NTk3Mw== shoyer 1217238 2017-05-21T19:04:26Z 2017-05-21T19:04:26Z MEMBER

thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dl tutorial files to tmp directory, then move them once successful 225672435
298966173 https://github.com/pydata/xarray/pull/1393#issuecomment-298966173 https://api.github.com/repos/pydata/xarray/issues/1393 MDEyOklzc3VlQ29tbWVudDI5ODk2NjE3Mw== shoyer 1217238 2017-05-03T16:38:02Z 2017-05-03T16:38:02Z MEMBER

I'd be slightly more comfortable if we had this being unit tested on Travis-CI, but that's somewhat tricky to setup because we don't wan to require network access for the test suite by default. You could do this by adding a flag like --run-network-tests in conftest.py, and then hooking it through in xarray/tests/__init__.py like --run-flaky. I would be awesome if you could take a look at that and set the Travis/Appveyor tests to test the tutorial, but isn't strictly required to merge this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dl tutorial files to tmp directory, then move them once successful 225672435
298964022 https://github.com/pydata/xarray/pull/1393#issuecomment-298964022 https://api.github.com/repos/pydata/xarray/issues/1393 MDEyOklzc3VlQ29tbWVudDI5ODk2NDAyMg== shoyer 1217238 2017-05-03T16:30:01Z 2017-05-03T16:30:01Z MEMBER

Thanks @gidden, this look great to me. Could you kindly add a brief note to the "Bug fixes" section of whats-new.rst?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dl tutorial files to tmp directory, then move them once successful 225672435
298737305 https://github.com/pydata/xarray/pull/1393#issuecomment-298737305 https://api.github.com/repos/pydata/xarray/issues/1393 MDEyOklzc3VlQ29tbWVudDI5ODczNzMwNQ== shoyer 1217238 2017-05-02T19:32:16Z 2017-05-02T19:32:16Z MEMBER

Thanks for taking this on @gidden.

Also not sure how best to import shutil. I followed the current pattern for os, but am not sure why that pattern exists in this file.

I think this exists to work around the fact that IPython shows everything that isn't private in auto-complete (https://github.com/ipython/ipykernel/issues/129). But we should probably switch back to normal imports in this module -- this is really more of an IPython issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dl tutorial files to tmp directory, then move them once successful 225672435

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);