home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 298966173

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1393#issuecomment-298966173 https://api.github.com/repos/pydata/xarray/issues/1393 298966173 MDEyOklzc3VlQ29tbWVudDI5ODk2NjE3Mw== 1217238 2017-05-03T16:38:02Z 2017-05-03T16:38:02Z MEMBER

I'd be slightly more comfortable if we had this being unit tested on Travis-CI, but that's somewhat tricky to setup because we don't wan to require network access for the test suite by default. You could do this by adding a flag like --run-network-tests in conftest.py, and then hooking it through in xarray/tests/__init__.py like --run-flaky. I would be awesome if you could take a look at that and set the Travis/Appveyor tests to test the tutorial, but isn't strictly required to merge this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  225672435
Powered by Datasette · Queries took 556.679ms · About: xarray-datasette