issue_comments

Table actions

16 rows where issue = 225222227 and user = 5572303 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • chunweiyuan · 16 ✖

issue 1

  • Sortby · 16 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
301135310 https://github.com/pydata/xarray/pull/1389#issuecomment-301135310 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMTEzNTMxMA== chunweiyuan 5572303 2017-05-12T17:18:49Z 2017-05-12T17:18:49Z CONTRIBUTOR

Thank you very much for your patience!

BTW, I think I messed up my co-worker's name in whats-new.rst. The spelling is right (Kyle Heuton), but the extra indentation shouldn't be there. As a result his name appears a bit out of place. Would be very much obliged if you could fix that in your next push to master. Gracias.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300947995 https://github.com/pydata/xarray/pull/1389#issuecomment-300947995 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDk0Nzk5NQ== chunweiyuan 5572303 2017-05-11T23:59:29Z 2017-05-11T23:59:29Z CONTRIBUTOR

api.rst should've been a checklist item :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300850103 https://github.com/pydata/xarray/pull/1389#issuecomment-300850103 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDg1MDEwMw== chunweiyuan 5572303 2017-05-11T16:51:34Z 2017-05-11T16:51:34Z CONTRIBUTOR

If that's the case then I have nothing more to add. I've run flake8 on the individual files I touched I as well, such as flake8 xarray/core/dataset.py, and none of my changes are flagged.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300675689 https://github.com/pydata/xarray/pull/1389#issuecomment-300675689 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDY3NTY4OQ== chunweiyuan 5572303 2017-05-11T03:55:58Z 2017-05-11T03:55:58Z CONTRIBUTOR

git diff upstream/master | flake8 --diff only complains about a bunch of lines in whats-new.rst and reshaping.rst. But these complaints don't make any sense to me. Some examples: doc/reshaping.rst:195:1: E112 expected an indented block doc/reshaping.rst:203:1: E101 indentation contains mixed spaces and tabs doc/reshaping.rst:203:1: W191 indentation contains tabs doc/reshaping.rst:203:2: E113 unexpected indentation I've played around with it a bit but not seen any changes to the complaints. What is going on? Should I even worry about the .rst files?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300600778 https://github.com/pydata/xarray/pull/1389#issuecomment-300600778 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDYwMDc3OA== chunweiyuan 5572303 2017-05-10T20:20:12Z 2017-05-10T20:20:12Z CONTRIBUTOR

Haha, brilliant.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300566860 https://github.com/pydata/xarray/pull/1389#issuecomment-300566860 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDU2Njg2MA== chunweiyuan 5572303 2017-05-10T18:08:33Z 2017-05-10T18:08:33Z CONTRIBUTOR

I just made some futile attempts to find that checklist, to no avail. Mind helping me with a link? :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300555321 https://github.com/pydata/xarray/pull/1389#issuecomment-300555321 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDU1NTMyMQ== chunweiyuan 5572303 2017-05-10T17:30:32Z 2017-05-10T17:30:32Z CONTRIBUTOR

Today is the first time I've heard of flake8. Is this how you guys standardize quality checks? If so, do you run once for python 3.5 and once for 2.7?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300534562 https://github.com/pydata/xarray/pull/1389#issuecomment-300534562 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDUzNDU2Mg== chunweiyuan 5572303 2017-05-10T16:16:28Z 2017-05-10T16:16:28Z CONTRIBUTOR

Looks ready now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300306624 https://github.com/pydata/xarray/pull/1389#issuecomment-300306624 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDMwNjYyNA== chunweiyuan 5572303 2017-05-09T21:27:06Z 2017-05-09T21:27:06Z CONTRIBUTOR

Think I just copied something over from variable.py and changed the message a little bit...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300289437 https://github.com/pydata/xarray/pull/1389#issuecomment-300289437 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDI4OTQzNw== chunweiyuan 5572303 2017-05-09T20:20:44Z 2017-05-09T20:20:44Z CONTRIBUTOR

From numpy 1.11.0 release notes: ``` np.lexsort now supports arrays with object data-type

The function now internally calls the generic npy_amergesort when the type does not implement a merge-sort kind of argsort method. ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300283451 https://github.com/pydata/xarray/pull/1389#issuecomment-300283451 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDI4MzQ1MQ== chunweiyuan 5572303 2017-05-09T19:57:39Z 2017-05-09T19:57:39Z CONTRIBUTOR

1.10.4 failed with the merge sort error. 1.11.0 failed with some error that had nothing to do with merge sort (Reason: image not found. Make sure your test modules/packages have valid Python names.) Starting from 1.11.1 it works fine.

What's the best course of action now?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300267772 https://github.com/pydata/xarray/pull/1389#issuecomment-300267772 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDI2Nzc3Mg== chunweiyuan 5572303 2017-05-09T18:57:51Z 2017-05-09T18:57:51Z CONTRIBUTOR

If I downgrade to numpy 1.10, I get that error. Once upgraded to 1.12, it goes away...... 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
300029141 https://github.com/pydata/xarray/pull/1389#issuecomment-300029141 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDMwMDAyOTE0MQ== chunweiyuan 5572303 2017-05-09T00:39:44Z 2017-05-09T00:39:44Z CONTRIBUTOR

Perhaps it's finally ready for prime time?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
299645639 https://github.com/pydata/xarray/pull/1389#issuecomment-299645639 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDI5OTY0NTYzOQ== chunweiyuan 5572303 2017-05-06T15:04:31Z 2017-05-06T15:04:31Z CONTRIBUTOR

I've added a tiny bit of extra docstring just to ease my discomfort about the NaN sort. If you feel it's redundant I can remove it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
299230655 https://github.com/pydata/xarray/pull/1389#issuecomment-299230655 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDI5OTIzMDY1NQ== chunweiyuan 5572303 2017-05-04T16:01:45Z 2017-05-04T16:01:45Z CONTRIBUTOR

Almost time to merge this baby in? :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227
298365438 https://github.com/pydata/xarray/pull/1389#issuecomment-298365438 https://api.github.com/repos/pydata/xarray/issues/1389 MDEyOklzc3VlQ29tbWVudDI5ODM2NTQzOA== chunweiyuan 5572303 2017-05-01T16:18:55Z 2017-05-01T16:18:55Z CONTRIBUTOR

Weird. Travis seems to fail in places unrelated to my changes.

I'm rather agnostic to sortby vs. sort_by.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Sortby 225222227

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);