issue_comments

Table actions

3 rows where issue = 218745734 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • Support for DataArray.expand_dims() · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
292826966 https://github.com/pydata/xarray/pull/1347#issuecomment-292826966 https://api.github.com/repos/pydata/xarray/issues/1347 MDEyOklzc3VlQ29tbWVudDI5MjgyNjk2Ng== shoyer 1217238 2017-04-10T01:02:06Z 2017-04-10T01:02:18Z MEMBER

This looks great. Thank you @fujiisoup!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support for DataArray.expand_dims() 218745734
291189965 https://github.com/pydata/xarray/pull/1347#issuecomment-291189965 https://api.github.com/repos/pydata/xarray/issues/1347 MDEyOklzc3VlQ29tbWVudDI5MTE4OTk2NQ== shoyer 1217238 2017-04-03T16:06:10Z 2017-04-03T16:06:10Z MEMBER

How can I add API docs? Only to add a single line to api.rst?

Yes, that's correct.

I changed my mind. reshape sounds too general. How about append_dims or attach_dims ?

Indeed, I would rather not do reshape, because this method does not support arbitrary reshaping (e.g., length 100 vector-> 10x10 matrix). Instead, it assigns dimensions using array broadcasting and transpose, which unlike reshape does not ever copy data. Maybe set_dims would be better? I also would be OK with attach_dims. append_dims makes it sound like dimensions are always appended (they aren't).

Actually, reshape could indeed be a nice method to add to Dataset/DataArray, as an alternative to stack/unstack.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support for DataArray.expand_dims() 218745734
291009605 https://github.com/pydata/xarray/pull/1347#issuecomment-291009605 https://api.github.com/repos/pydata/xarray/issues/1347 MDEyOklzc3VlQ29tbWVudDI5MTAwOTYwNQ== shoyer 1217238 2017-04-02T19:39:59Z 2017-04-02T19:39:59Z MEMBER

The proposed API is similar to numpy.expand_dims and slightly different from Variables.expand_dims, which requires whole sequences of dims of the result array.

This looks great, but to avoid confusion, can we rename the existing Variable.expand_dims method? Maybe with_dims would be a clearer name.

My concern is that I do not yet fully understand the lazy data manipulation in xarray. Does Variable.expand_dims do it?

Yes, Variable.expand_dims is already lazy on dask arrays.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support for DataArray.expand_dims() 218745734

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);