issue_comments: 291009605

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1347#issuecomment-291009605 https://api.github.com/repos/pydata/xarray/issues/1347 291009605 MDEyOklzc3VlQ29tbWVudDI5MTAwOTYwNQ== 1217238 2017-04-02T19:39:59Z 2017-04-02T19:39:59Z MEMBER

The proposed API is similar to numpy.expand_dims and slightly different from Variables.expand_dims, which requires whole sequences of dims of the result array.

This looks great, but to avoid confusion, can we rename the existing Variable.expand_dims method? Maybe with_dims would be a clearer name.

My concern is that I do not yet fully understand the lazy data manipulation in xarray. Does Variable.expand_dims do it?

Yes, Variable.expand_dims is already lazy on dask arrays.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   218745734