issue_comments

Table actions

3 rows where issue = 213265588 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Clarify licenses for bundled code · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
285733086 https://github.com/pydata/xarray/pull/1305#issuecomment-285733086 https://api.github.com/repos/pydata/xarray/issues/1305 MDEyOklzc3VlQ29tbWVudDI4NTczMzA4Ng== ghisvail 1964655 2017-03-10T17:34:17Z 2017-03-10T17:34:17Z CONTRIBUTOR

I really fail to understand how much of a bug deal it is to introduce a NOTICE file with the right content and keep the LICENSE file and the rest of the code base unchanged. It cannot get any simpler than this.

Anyway, your commit provided the missing copyright information I was seeking. For the rest, I gave you a piece of advice for easy compliance (the NOTICE file) and you are free to follow or disregard it. Moving on.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify licenses for bundled code 213265588
285726462 https://github.com/pydata/xarray/pull/1305#issuecomment-285726462 https://api.github.com/repos/pydata/xarray/issues/1305 MDEyOklzc3VlQ29tbWVudDI4NTcyNjQ2Mg== shoyer 1217238 2017-03-10T17:08:55Z 2017-03-10T17:08:55Z MEMBER

To add a little more context on my considerations here, for Apache projects that bundle permissively licensed dependencies (like what we've done here), they actually add a note to LICENSE directly instead of NOTICE: http://www.apache.org/dev/licensing-howto.html#permissive-deps

We could take this approach, but it has the downside of breaking tools that automatically parse LICENSE such as GItHub itself at the top of each repository. One could argue that that's a feature, not a bug, but I think it's better to show the main license at first glance (almost every large project has some bundled dependencies). Apache Spark is a good example: https://github.com/apache/spark

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify licenses for bundled code 213265588
285612429 https://github.com/pydata/xarray/pull/1305#issuecomment-285612429 https://api.github.com/repos/pydata/xarray/issues/1305 MDEyOklzc3VlQ29tbWVudDI4NTYxMjQyOQ== fmaussion 10050469 2017-03-10T08:50:20Z 2017-03-10T08:50:20Z MEMBER

Great!

cc @ghisvail 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify licenses for bundled code 213265588

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);