issue_comments: 285726462

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1305#issuecomment-285726462 https://api.github.com/repos/pydata/xarray/issues/1305 285726462 MDEyOklzc3VlQ29tbWVudDI4NTcyNjQ2Mg== 1217238 2017-03-10T17:08:55Z 2017-03-10T17:08:55Z MEMBER

To add a little more context on my considerations here, for Apache projects that bundle permissively licensed dependencies (like what we've done here), they actually add a note to LICENSE directly instead of NOTICE: http://www.apache.org/dev/licensing-howto.html#permissive-deps

We could take this approach, but it has the downside of breaking tools that automatically parse LICENSE such as GItHub itself at the top of each repository. One could argue that that's a feature, not a bug, but I think it's better to show the main license at first glance (almost every large project has some bundled dependencies). Apache Spark is a good example: https://github.com/apache/spark

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   213265588