issue_comments

Table actions

5 rows where issue = 208215185 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • Groupby-like API for resampling · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
331283075 https://github.com/pydata/xarray/pull/1272#issuecomment-331283075 https://api.github.com/repos/pydata/xarray/issues/1272 MDEyOklzc3VlQ29tbWVudDMzMTI4MzA3NQ== shoyer 1217238 2017-09-21T21:11:07Z 2017-09-21T21:11:07Z MEMBER

We just bumped numpy to 1.11, but 1.12 would be too new.

Let's just add a np.flip backport to core/npcompat.py. The whole function is only a couple of lines.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Groupby-like API for resampling 208215185
324175792 https://github.com/pydata/xarray/pull/1272#issuecomment-324175792 https://api.github.com/repos/pydata/xarray/issues/1272 MDEyOklzc3VlQ29tbWVudDMyNDE3NTc5Mg== shoyer 1217238 2017-08-22T23:05:49Z 2017-08-22T23:05:49Z MEMBER

I've opted not to include a chart outlining the various upsampling options...

This is OK by me

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Groupby-like API for resampling 208215185
323500774 https://github.com/pydata/xarray/pull/1272#issuecomment-323500774 https://api.github.com/repos/pydata/xarray/issues/1272 MDEyOklzc3VlQ29tbWVudDMyMzUwMDc3NA== shoyer 1217238 2017-08-19T04:58:56Z 2017-08-19T04:58:56Z MEMBER

I like your approach here! Just some various comments on the implementation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Groupby-like API for resampling 208215185
283473505 https://github.com/pydata/xarray/pull/1272#issuecomment-283473505 https://api.github.com/repos/pydata/xarray/issues/1272 MDEyOklzc3VlQ29tbWVudDI4MzQ3MzUwNQ== shoyer 1217238 2017-03-01T21:19:13Z 2017-03-01T21:19:13Z MEMBER

I can't really find many examples of people using this as a substitute for time group-bys... it seems that's what the pd.TimeGrouper is for, in conjunction with a normal .groupby().

I think this is mostly because TimeGrouper has been around far longer than non-aggregating resample.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Groupby-like API for resampling 208215185
281189948 https://github.com/pydata/xarray/pull/1272#issuecomment-281189948 https://api.github.com/repos/pydata/xarray/issues/1272 MDEyOklzc3VlQ29tbWVudDI4MTE4OTk0OA== shoyer 1217238 2017-02-20T21:50:05Z 2017-02-20T21:50:05Z MEMBER

The only issue now is the signature for init() in Data{set,Array}Resample, where we have to add in two keyword arguments. Python 2.x doesn't like named arguments after args. There are a few options here, mostly just playing with *kwargs as in this StackOverflow thread.

Yes, use pop, e.g., dim = kwargs.pop('dim', None). pop removes the arguments from kwargs, so you can pass on the remaining ones unchanged to the super class method.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Groupby-like API for resampling 208215185

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);