issue_comments: 281189948

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1272#issuecomment-281189948 https://api.github.com/repos/pydata/xarray/issues/1272 281189948 MDEyOklzc3VlQ29tbWVudDI4MTE4OTk0OA== 1217238 2017-02-20T21:50:05Z 2017-02-20T21:50:05Z MEMBER

The only issue now is the signature for init() in Data{set,Array}Resample, where we have to add in two keyword arguments. Python 2.x doesn't like named arguments after args. There are a few options here, mostly just playing with *kwargs as in this StackOverflow thread.

Yes, use pop, e.g., dim = kwargs.pop('dim', None). pop removes the arguments from kwargs, so you can pass on the remaining ones unchanged to the super class method.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   208215185