issue_comments

Table actions

2 rows where issue = 207962322 and user = 6815844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fujiisoup · 2 ✖

issue 1

  • Attrs are lost in mathematical computation · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
280838479 https://github.com/pydata/xarray/issues/1271#issuecomment-280838479 https://api.github.com/repos/pydata/xarray/issues/1271 MDEyOklzc3VlQ29tbWVudDI4MDgzODQ3OQ== fujiisoup 6815844 2017-02-18T11:03:42Z 2017-02-18T11:03:42Z MEMBER

I would strong prefer to avoid making the xarray data model more complex by adding another type of metadata (e.g., in addition to dims, coords, attrs and name on DataArray). Whitelisting specific attrs as ones that should be preserved in application code via set_options (or encouraging users to subclass DataArray in a "safe" way) is preferable in that regard.

Understood. I close this issue. I guess discussions for how this option would be implemented could be continued in #988.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Attrs are lost in mathematical computation 207962322
280252632 https://github.com/pydata/xarray/issues/1271#issuecomment-280252632 https://api.github.com/repos/pydata/xarray/issues/1271 MDEyOklzc3VlQ29tbWVudDI4MDI1MjYzMg== fujiisoup 6815844 2017-02-16T07:24:14Z 2017-02-16T07:24:14Z MEMBER

Thank you for the information. I agree that we should not strongly rely on attrs. Unit may change in arithmetic.

My sense is closest to the option 3 in #131. Some attrs should be tracked and other should be dropped. In the present stage, the most possible option is to add keep_attrs in xr.set_options? Or any destructive change will be an option? Such as to divide attrs into two kinds, units and metadata.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Attrs are lost in mathematical computation 207962322

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);