home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 280252632

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1271#issuecomment-280252632 https://api.github.com/repos/pydata/xarray/issues/1271 280252632 MDEyOklzc3VlQ29tbWVudDI4MDI1MjYzMg== 6815844 2017-02-16T07:24:14Z 2017-02-16T07:24:14Z MEMBER

Thank you for the information. I agree that we should not strongly rely on attrs. Unit may change in arithmetic.

My sense is closest to the option 3 in #131. Some attrs should be tracked and other should be dropped. In the present stage, the most possible option is to add keep_attrs in xr.set_options? Or any destructive change will be an option? Such as to divide attrs into two kinds, units and metadata.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  207962322
Powered by Datasette · Queries took 0.915ms · About: xarray-datasette