issue_comments

Table actions

4 rows where issue = 206137485 and user = 1964655 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • ghisvail · 4 ✖

issue 1

  • Provide more detailed copyright information · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
282557948 https://github.com/pydata/xarray/issues/1254#issuecomment-282557948 https://api.github.com/repos/pydata/xarray/issues/1254 MDEyOklzc3VlQ29tbWVudDI4MjU1Nzk0OA== ghisvail 1964655 2017-02-26T14:02:48Z 2017-02-26T14:02:48Z CONTRIBUTOR

FYI, xarray is now available in Debian.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Provide more detailed copyright information 206137485
278698787 https://github.com/pydata/xarray/issues/1254#issuecomment-278698787 https://api.github.com/repos/pydata/xarray/issues/1254 MDEyOklzc3VlQ29tbWVudDI3ODY5ODc4Nw== ghisvail 1964655 2017-02-09T16:43:22Z 2017-02-09T16:43:22Z CONTRIBUTOR

The complex bit of code embedding is that both MIT and BSD have a clause saying that redistribution from source (even partially) should keep the original copyright notice (which includes authors, dates and license summary). It is straightforward to do when the original file is untouched, however things get a bit more difficult when portions of code gets included in larger modules, or so-called "compatibility" modules, where there is an aggregate of code with mixed copyright.

That's why the NOTICE file is useful. You just have to aggregate all copyright information in this one file and you are guaranteed to comply. Besides, commercial entities or packagers like myself, who need to survey the compliance of each software, have an easier time doing their work.

Did my explanation make sense?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Provide more detailed copyright information 206137485
278693067 https://github.com/pydata/xarray/issues/1254#issuecomment-278693067 https://api.github.com/repos/pydata/xarray/issues/1254 MDEyOklzc3VlQ29tbWVudDI3ODY5MzA2Nw== ghisvail 1964655 2017-02-09T16:25:24Z 2017-02-09T16:25:24Z CONTRIBUTOR

Most Apache-licensed software follow these guidelines, nonetheless. And for the case of xarray, where there are instances of embedded code from other copyrighted projects, I believe it should be beneficial to follow these conventions too. The final decision is yours at the end.

Regardless of your decision, I need a comprehensive list of all embedded code which falls under a different copyright than xarray.

Thanks,

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Provide more detailed copyright information 206137485
278590912 https://github.com/pydata/xarray/issues/1254#issuecomment-278590912 https://api.github.com/repos/pydata/xarray/issues/1254 MDEyOklzc3VlQ29tbWVudDI3ODU5MDkxMg== ghisvail 1964655 2017-02-09T09:32:36Z 2017-02-09T09:32:36Z CONTRIBUTOR

Probably we should include text of each license at the appropriate locations, or at least a direct reference to the fact hat it has a different license.

That is indeed the purpose of the NOTICE file. Since the Apache license state that all source code should start with the Apache copyright header, then individual copyrights from embedded portions of code should be listed in an additional NOTICE file to comply with their respective redistribution clauses.

I'm not opposed to adding a NOTICE file

You do know you are supposed to provide one as per the Apache Software Policy, right? Details about its content and formatting are provided here.

I am also providing an example from the ITK project, since you seem to be having doubts about my statement. I can give you many more if your are still not convinced.

but I haven't seen it in other projects in the scientific Python space

Because most projects from the scientific Python stack (including Numpy and Pandas that you mentioned) use the simpler BSD-3-Clause.

Maybe we're all just being careless, though :)

Nope, just yourself in this case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Provide more detailed copyright information 206137485

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);