issue_comments

Table actions

4 rows where issue = 195832230 and user = 3217406 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • laliberte · 4 ✖

issue 1

  • Set a default _FillValue of NaN for float types · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
267492795 https://github.com/pydata/xarray/pull/1165#issuecomment-267492795 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDI2NzQ5Mjc5NQ== laliberte 3217406 2016-12-16T01:21:30Z 2016-12-16T01:21:30Z CONTRIBUTOR

@shoyer Let me know if you need any more changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230
267392582 https://github.com/pydata/xarray/pull/1165#issuecomment-267392582 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDI2NzM5MjU4Mg== laliberte 3217406 2016-12-15T17:43:21Z 2016-12-15T17:43:21Z CONTRIBUTOR

So I've tried with conventions.py and it works. However, allowing a NaN _FillValue for complex floats raises an exception in h5py: h5py/h5py#805. This means that until this is fixed in h5py we should restrict this default behaviour to real float types.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230
267371351 https://github.com/pydata/xarray/pull/1165#issuecomment-267371351 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDI2NzM3MTM1MQ== laliberte 3217406 2016-12-15T16:23:41Z 2016-12-15T16:23:41Z CONTRIBUTOR

I know but the alternative would be to scan the data before deciding but that would kind of break the whole dask integration.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230
267366770 https://github.com/pydata/xarray/pull/1165#issuecomment-267366770 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDI2NzM2Njc3MA== laliberte 3217406 2016-12-15T16:07:45Z 2016-12-15T16:07:45Z CONTRIBUTOR

The only problem I see is that in the current implementation this fix puts a _FillValue attribute even if there are no NaN in the variable. Usually, cdo would not do that. I guess there are little risks but I think it's important that this be said. Alternative implementations would be way too cumbersome so I think the approach used in this PR is the lesser of two evils.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);