issue_comments: 267366770

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1165#issuecomment-267366770 https://api.github.com/repos/pydata/xarray/issues/1165 267366770 MDEyOklzc3VlQ29tbWVudDI2NzM2Njc3MA== 3217406 2016-12-15T16:07:45Z 2016-12-15T16:07:45Z CONTRIBUTOR

The only problem I see is that in the current implementation this fix puts a _FillValue attribute even if there are no NaN in the variable. Usually, cdo would not do that. I guess there are little risks but I think it's important that this be said. Alternative implementations would be way too cumbersome so I think the approach used in this PR is the lesser of two evils.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   195832230