issue_comments

Table actions

5 rows where issue = 189095110 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • Do not convert subclasses of `ndarray` unless required · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
288290759 https://github.com/pydata/xarray/pull/1118#issuecomment-288290759 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI4ODI5MDc1OQ== shoyer 1217238 2017-03-22T03:48:07Z 2017-03-22T03:49:47Z MEMBER

@lamorton This branch has conflicts with master (due to #1128) that need to be resolved with a merge or rebase. But otherwise, I think this is nearly ready to go in. Obviously it's not a complete fix, but it might be enough to be useful.

If you want to take a shot at resolving merge conflicts in a new PR, I think that would be welcome (I doubt @burnpanck is currently working on it).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
268940848 https://github.com/pydata/xarray/pull/1118#issuecomment-268940848 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2ODk0MDg0OA== shoyer 1217238 2016-12-23T04:57:36Z 2016-12-23T04:57:36Z MEMBER

1128 has been merged -- can you try rebasing? Thanks

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
261002724 https://github.com/pydata/xarray/pull/1118#issuecomment-261002724 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2MTAwMjcyNA== shoyer 1217238 2016-11-16T16:53:06Z 2016-11-16T16:53:06Z MEMBER

Indeed, the allowed failures are unrelated: https://github.com/pydata/xarray/issues/1109

See here for Appveyor installation: https://github.com/pydata/xarray/blob/master/appveyor.yml

It would be good to switch it use conda env for consistency but haven't gotten around to that yet (https://github.com/pydata/xarray/issues/1127)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
260711940 https://github.com/pydata/xarray/pull/1118#issuecomment-260711940 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2MDcxMTk0MA== shoyer 1217238 2016-11-15T17:41:16Z 2016-11-15T17:41:16Z MEMBER

It either uses conda (by default) or pip: https://github.com/conda/conda-env

Please do add it to everything, except perhaps the build with minimal dependencies (py27-min)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
260688914 https://github.com/pydata/xarray/pull/1118#issuecomment-260688914 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2MDY4ODkxNA== shoyer 1217238 2016-11-15T16:23:07Z 2016-11-15T16:23:07Z MEMBER

This does seem pretty reasonable to me.

But is this actually running in CI? I think you need to add quantities to requirements.yml files to get this to run in Travis-CI: https://github.com/pydata/xarray/tree/master/ci

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);