issue_comments

Table actions

13 rows where issue = 189095110 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Do not convert subclasses of `ndarray` unless required · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
568903769 https://github.com/pydata/xarray/pull/1118#issuecomment-568903769 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDU2ODkwMzc2OQ== keewis 14808389 2019-12-25T14:12:33Z 2019-12-25T14:12:33Z MEMBER

closing for the same reason as #2956 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
491636217 https://github.com/pydata/xarray/pull/1118#issuecomment-491636217 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDQ5MTYzNjIxNw== max-sixty 5635139 2019-05-12T22:54:26Z 2019-05-12T22:54:26Z MEMBER

Hi @keewis - yes!

You can start a new PR by branching off this PR (https://help.github.com/en/articles/checking-out-pull-requests-locally). I think you'll find GH easy to use - feel free to ping here with any issues and we'll be happy to help

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
491620350 https://github.com/pydata/xarray/pull/1118#issuecomment-491620350 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDQ5MTYyMDM1MA== keewis 14808389 2019-05-12T19:01:19Z 2019-05-12T19:01:19Z MEMBER

Is this still relevant? If so, I'd be willing to take over. However, I am not really familiar with github yet: would I open a new pull request for that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
454165086 https://github.com/pydata/xarray/pull/1118#issuecomment-454165086 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDQ1NDE2NTA4Ng== max-sixty 5635139 2019-01-14T21:18:42Z 2019-01-14T21:18:42Z MEMBER

Would anyone like to take this up? I was going to close as stale, but it's fairly close!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
288290759 https://github.com/pydata/xarray/pull/1118#issuecomment-288290759 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI4ODI5MDc1OQ== shoyer 1217238 2017-03-22T03:48:07Z 2017-03-22T03:49:47Z MEMBER

@lamorton This branch has conflicts with master (due to #1128) that need to be resolved with a merge or rebase. But otherwise, I think this is nearly ready to go in. Obviously it's not a complete fix, but it might be enough to be useful.

If you want to take a shot at resolving merge conflicts in a new PR, I think that would be welcome (I doubt @burnpanck is currently working on it).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
287861154 https://github.com/pydata/xarray/pull/1118#issuecomment-287861154 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI4Nzg2MTE1NA== lamorton 23484003 2017-03-20T18:51:44Z 2017-03-20T18:51:44Z NONE

Is there anything I can do to help move this forward? I'd really like to have this capability.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
268940848 https://github.com/pydata/xarray/pull/1118#issuecomment-268940848 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2ODk0MDg0OA== shoyer 1217238 2016-12-23T04:57:36Z 2016-12-23T04:57:36Z MEMBER

1128 has been merged -- can you try rebasing? Thanks

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
261551610 https://github.com/pydata/xarray/pull/1118#issuecomment-261551610 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2MTU1MTYxMA== burnpanck 1310437 2016-11-18T14:58:24Z 2016-11-18T14:58:24Z CONTRIBUTOR

With the new changes, this will now conflict with #1128, though easy to solve.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
261002724 https://github.com/pydata/xarray/pull/1118#issuecomment-261002724 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2MTAwMjcyNA== shoyer 1217238 2016-11-16T16:53:06Z 2016-11-16T16:53:06Z MEMBER

Indeed, the allowed failures are unrelated: https://github.com/pydata/xarray/issues/1109

See here for Appveyor installation: https://github.com/pydata/xarray/blob/master/appveyor.yml

It would be good to switch it use conda env for consistency but haven't gotten around to that yet (https://github.com/pydata/xarray/issues/1127)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
260916046 https://github.com/pydata/xarray/pull/1118#issuecomment-260916046 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2MDkxNjA0Ng== burnpanck 1310437 2016-11-16T10:55:00Z 2016-11-16T10:55:00Z CONTRIBUTOR

Travis succeeds, though lots of failures under environments with allowed failure. They look unrelated to me, but I find it hard to tell. Appveyor doesn't seem to run the quantities tests, so I guess the requirements there are missing too. Where would I add requirements for Appveyor?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
260711940 https://github.com/pydata/xarray/pull/1118#issuecomment-260711940 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2MDcxMTk0MA== shoyer 1217238 2016-11-15T17:41:16Z 2016-11-15T17:41:16Z MEMBER

It either uses conda (by default) or pip: https://github.com/conda/conda-env

Please do add it to everything, except perhaps the build with minimal dependencies (py27-min)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
260710056 https://github.com/pydata/xarray/pull/1118#issuecomment-260710056 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2MDcxMDA1Ng== burnpanck 1310437 2016-11-15T17:34:15Z 2016-11-15T17:34:15Z CONTRIBUTOR

You are right. There seem to be quite a number of varying requirements. Should I add it to all of them? Also, I'm not very well versed in Travis-CI .yml: What repo are the requirements served from? I think python-quantities is in debian. Or should I just go for pip? There hasn't been a release in a long time, github master has progressed quite a bit, but the released version should be compatible too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110
260688914 https://github.com/pydata/xarray/pull/1118#issuecomment-260688914 https://api.github.com/repos/pydata/xarray/issues/1118 MDEyOklzc3VlQ29tbWVudDI2MDY4ODkxNA== shoyer 1217238 2016-11-15T16:23:07Z 2016-11-15T16:23:07Z MEMBER

This does seem pretty reasonable to me.

But is this actually running in CI? I think you need to add quantities to requirements.yml files to get this to run in Travis-CI: https://github.com/pydata/xarray/tree/master/ci

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Do not convert subclasses of `ndarray` unless required 189095110

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);