issue_comments

Table actions

5 rows where issue = 183218516 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Preserve variables order in Dataset.concat() · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
257748638 https://github.com/pydata/xarray/pull/1049#issuecomment-257748638 https://api.github.com/repos/pydata/xarray/issues/1049 MDEyOklzc3VlQ29tbWVudDI1Nzc0ODYzOA== shoyer 1217238 2016-11-02T01:35:49Z 2016-11-02T01:35:49Z MEMBER

OK, I'm just going to merge this. We can iterate on this more later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve variables order in Dataset.concat() 183218516
254814590 https://github.com/pydata/xarray/pull/1049#issuecomment-254814590 https://api.github.com/repos/pydata/xarray/issues/1049 MDEyOklzc3VlQ29tbWVudDI1NDgxNDU5MA== fmaussion 10050469 2016-10-19T13:37:21Z 2016-10-19T13:37:21Z MEMBER

You could probably do this by consolidating the two loops over all variables. But up to you if you want to go through the trouble.

@shoyer could you elaborate on that? If there's a way to make it right I am happy to try, but I'm afraid I'm not sure what is the way to go. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve variables order in Dataset.concat() 183218516
254015789 https://github.com/pydata/xarray/pull/1049#issuecomment-254015789 https://api.github.com/repos/pydata/xarray/issues/1049 MDEyOklzc3VlQ29tbWVudDI1NDAxNTc4OQ== fmaussion 10050469 2016-10-15T22:49:54Z 2016-10-15T22:49:54Z MEMBER

Ok, done. The second problem about the coordinate variable seems trickier to solve though...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve variables order in Dataset.concat() 183218516
254005880 https://github.com/pydata/xarray/pull/1049#issuecomment-254005880 https://api.github.com/repos/pydata/xarray/issues/1049 MDEyOklzc3VlQ29tbWVudDI1NDAwNTg4MA== shoyer 1217238 2016-10-15T19:30:15Z 2016-10-15T19:30:15Z MEMBER

Alternatively, it looks like the issue is on line 266 where we iterate for k in concat_over. Instead, we could just do:

for k in variables: if k in concat_over: ...

This has the advantage of preserving the set, which is important if there is a very large number of variables.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve variables order in Dataset.concat() 183218516
254005549 https://github.com/pydata/xarray/pull/1049#issuecomment-254005549 https://api.github.com/repos/pydata/xarray/issues/1049 MDEyOklzc3VlQ29tbWVudDI1NDAwNTU0OQ== shoyer 1217238 2016-10-15T19:25:26Z 2016-10-15T19:25:26Z MEMBER

Agreed, this is the better approach. Thanks for diving into this!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve variables order in Dataset.concat() 183218516

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);