home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 254005880

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1049#issuecomment-254005880 https://api.github.com/repos/pydata/xarray/issues/1049 254005880 MDEyOklzc3VlQ29tbWVudDI1NDAwNTg4MA== 1217238 2016-10-15T19:30:15Z 2016-10-15T19:30:15Z MEMBER

Alternatively, it looks like the issue is on line 266 where we iterate for k in concat_over. Instead, we could just do:

for k in variables: if k in concat_over: ...

This has the advantage of preserving the set, which is important if there is a very large number of variables.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  183218516
Powered by Datasette · Queries took 0.629ms · About: xarray-datasette