issue_comments

Table actions

5 rows where issue = 180756013 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • test_conventions.TestEncodeCFVariable failing on master for Appveyor Python 2.7 build · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
255495015 https://github.com/pydata/xarray/issues/1034#issuecomment-255495015 https://api.github.com/repos/pydata/xarray/issues/1034 MDEyOklzc3VlQ29tbWVudDI1NTQ5NTAxNQ== shoyer 1217238 2016-10-22T00:32:17Z 2016-10-22T00:32:17Z MEMBER

We're getting a sensible AssertionError now:

``` __ TestEncodeCFVariable.testmissing_fillvalue ___ self = <xarray.test.test_conventions.TestEncodeCFVariable testMethod=test_missing_fillvalue> def test_missing_fillvalue(self): v = Variable(['x'], np.array([np.nan, 1, 2, 3])) v.encoding = {'dtype': 'int16'} with self.assertWarns('floating point data as an integer'):

      conventions.encode_cf_variable(v)

xarray\test\test_conventions.py:523:

C:\Python27-conda32\lib\contextlib.py:24: in exit self.gen.next()

self = <xarray.test.test_conventions.TestEncodeCFVariable testMethod=test_missing_fillvalue> message = 'floating point data as an integer' @contextmanager def assertWarns(self, message): with warnings.catch_warnings(record=True) as w: warnings.filterwarnings('always', message) yield assert len(w) > 0

      assert all(message in str(wi.message) for wi in w)

E AssertionError xarray\test__init__.py:140: AssertionError ```

I guess this was probably a py.test bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_conventions.TestEncodeCFVariable failing on master for Appveyor Python 2.7 build 180756013
251244928 https://github.com/pydata/xarray/issues/1034#issuecomment-251244928 https://api.github.com/repos/pydata/xarray/issues/1034 MDEyOklzc3VlQ29tbWVudDI1MTI0NDkyOA== max-sixty 5635139 2016-10-03T22:23:50Z 2016-10-03T22:23:50Z MEMBER

Hmmm, really weird. I'm guessing taking out TestCase and using the standard pytest way would solve it. (http://doc.pytest.org/en/latest/recwarn.html) But looks like a py.test break to me

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_conventions.TestEncodeCFVariable failing on master for Appveyor Python 2.7 build 180756013
251242505 https://github.com/pydata/xarray/issues/1034#issuecomment-251242505 https://api.github.com/repos/pydata/xarray/issues/1034 MDEyOklzc3VlQ29tbWVudDI1MTI0MjUwNQ== dopplershift 221526 2016-10-03T22:11:49Z 2016-10-03T22:11:49Z CONTRIBUTOR

I doubt it--that would shadow a built in exception:

``` pytb

print(foo) Traceback (most recent call last): File "<stdin>", line 1, in <module> NameError: name 'foo' is not defined ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_conventions.TestEncodeCFVariable failing on master for Appveyor Python 2.7 build 180756013
251241983 https://github.com/pydata/xarray/issues/1034#issuecomment-251241983 https://api.github.com/repos/pydata/xarray/issues/1034 MDEyOklzc3VlQ29tbWVudDI1MTI0MTk4Mw== shoyer 1217238 2016-10-03T22:09:17Z 2016-10-03T22:09:17Z MEMBER

Maybe the NameError is a weird pytest thing?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_conventions.TestEncodeCFVariable failing on master for Appveyor Python 2.7 build 180756013
251240211 https://github.com/pydata/xarray/issues/1034#issuecomment-251240211 https://api.github.com/repos/pydata/xarray/issues/1034 MDEyOklzc3VlQ29tbWVudDI1MTI0MDIxMQ== dopplershift 221526 2016-10-03T22:00:54Z 2016-10-03T22:00:54Z CONTRIBUTOR

It makes no sense that it's considering message a global here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_conventions.TestEncodeCFVariable failing on master for Appveyor Python 2.7 build 180756013

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);