issue_comments: 255495015

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1034#issuecomment-255495015 https://api.github.com/repos/pydata/xarray/issues/1034 255495015 MDEyOklzc3VlQ29tbWVudDI1NTQ5NTAxNQ== 1217238 2016-10-22T00:32:17Z 2016-10-22T00:32:17Z MEMBER

We're getting a sensible AssertionError now:

``` __ TestEncodeCFVariable.testmissing_fillvalue ___ self = <xarray.test.test_conventions.TestEncodeCFVariable testMethod=test_missing_fillvalue> def test_missing_fillvalue(self): v = Variable(['x'], np.array([np.nan, 1, 2, 3])) v.encoding = {'dtype': 'int16'} with self.assertWarns('floating point data as an integer'):

      conventions.encode_cf_variable(v)

xarray\test\test_conventions.py:523:

C:\Python27-conda32\lib\contextlib.py:24: in exit self.gen.next()

self = <xarray.test.test_conventions.TestEncodeCFVariable testMethod=test_missing_fillvalue> message = 'floating point data as an integer' @contextmanager def assertWarns(self, message): with warnings.catch_warnings(record=True) as w: warnings.filterwarnings('always', message) yield assert len(w) > 0

      assert all(message in str(wi.message) for wi in w)

E AssertionError xarray\test__init__.py:140: AssertionError ```

I guess this was probably a py.test bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   180756013