issue_comments

Table actions

4 rows where issue = 1722614979 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Name collision with Pulsar Timing package 'PINT' · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1562637946 https://github.com/pydata/xarray/issues/7870#issuecomment-1562637946 https://api.github.com/repos/pydata/xarray/issues/7870 IC_kwDOAMm_X85dI_Z6 keewis 14808389 2023-05-25T10:07:35Z 2023-05-25T10:07:35Z MEMBER

I agree, this change should be fine.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Name collision with Pulsar Timing package 'PINT'  1722614979
1562615805 https://github.com/pydata/xarray/issues/7870#issuecomment-1562615805 https://api.github.com/repos/pydata/xarray/issues/7870 IC_kwDOAMm_X85dI5_9 vhaasteren 3092444 2023-05-25T09:52:06Z 2023-05-25T09:52:06Z CONTRIBUTOR

Thank you @TomNicholas, that is encouraging to hear. I will wait for @keewis to respond before filing a PR.

FWIW, I have tested the modification I suggest in my fork of xarray, and it works well for our purposes. It just generalizes the exception catch.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Name collision with Pulsar Timing package 'PINT'  1722614979
1561543105 https://github.com/pydata/xarray/issues/7870#issuecomment-1561543105 https://api.github.com/repos/pydata/xarray/issues/7870 IC_kwDOAMm_X85dE0HB TomNicholas 35968931 2023-05-24T16:31:30Z 2023-05-24T16:31:30Z MEMBER

Thanks for raising this @vhaasteren ! We want to do what we can to support users from all fields of science :)

I would be okay with that change (especially as it's not really special-casing pint-pulsar, so much as generalizing an existing error-catching mechanism), but would defer to the opinion of @keewis on this.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Name collision with Pulsar Timing package 'PINT'  1722614979
1559971607 https://github.com/pydata/xarray/issues/7870#issuecomment-1559971607 https://api.github.com/repos/pydata/xarray/issues/7870 IC_kwDOAMm_X85c-0cX welcome[bot] 30606887 2023-05-23T18:54:19Z 2023-05-23T18:54:19Z NONE

Thanks for opening your first issue here at xarray! Be sure to follow the issue template! If you have an idea for a solution, we would really welcome a Pull Request with proposed changes. See the Contributing Guide for more. It may take us a while to respond here, but we really value your contribution. Contributors like you help make xarray better. Thank you!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Name collision with Pulsar Timing package 'PINT'  1722614979

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);