issue_comments

Table actions

3 rows where issue = 1641109066 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Allow track_order to be passed to h5netcdf · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1487444030 https://github.com/pydata/xarray/issues/7680#issuecomment-1487444030 https://api.github.com/repos/pydata/xarray/issues/7680 IC_kwDOAMm_X85YqJg- abunimeh 8106823 2023-03-28T18:53:29Z 2023-03-28T18:53:29Z NONE

Thanks @kmuehlbauer for explaining this.

@jhamman yes, i was hoping that I can pass ds.to_netcdf(..., track_order=False) when engine is hd5netcdf.

It would be nice to enhance backend_kwargs

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow track_order to be passed to h5netcdf 1641109066
1484583468 https://github.com/pydata/xarray/issues/7680#issuecomment-1484583468 https://api.github.com/repos/pydata/xarray/issues/7680 IC_kwDOAMm_X85YfPIs kmuehlbauer 5821660 2023-03-27T06:36:46Z 2023-03-27T06:50:55Z MEMBER

First, I totally agree with @jhamman having backend_kwargs on to_netcdf.

For the particular use case, netcdf-c/netCDF4-python create HDF5 files (NECTDF4-format) with track order enabled as required, see https://docs.unidata.ucar.edu/netcdf-c/current/file_format_specifications.html#creation_order.

h5netcdf uses track_order=True as default since version 1.1.0. There have been (and still are, https://github.com/HDFGroup/hdf5/issues/1388) some corner case issues upstream which netcdf-c can somehow circumvent, but h5netcdf can't. Nevertheless, to be compliant with netcdf-c track_order=True is default for h5netcdf.

@abunimeh As a workaround until this is sorted out you could create the file (or subgroup) using h5py/h5netcdf with track_order=False. If a file (root-group) or sub-group in a file is created with track_order=False this will be persistent as it is set at group-define time. Then you can use to_netcdf as usual with mode="a" to append.

```python

import xarray as xr import h5netcdf from time import sleep

ds = xr.Dataset(data_vars=dict(hello=(["x"], [1., 1., 1., 1., 1.])))

track_order = False group = "/track"

with h5netcdf.File("sample1.nc", "a", track_order=track_order) as f1: if group.split("/")[-1]: f1.create_group(group)

ds.to_netcdf("sample1.nc", mode="a", engine="h5netcdf", group=group)
sleep(5)

with h5netcdf.File("sample2.nc", "a", track_order=track_order) as f2: if group.split("/")[-1]: f2.create_group(group)

ds.to_netcdf("sample2.nc", mode="a", engine="h5netcdf", group=group)
```

Update: Use mode="a" everywhere. Update2: Cave: You will not be able to append to this file with netcdf-c/netCDF4-python ever again.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow track_order to be passed to h5netcdf 1641109066
1484386454 https://github.com/pydata/xarray/issues/7680#issuecomment-1484386454 https://api.github.com/repos/pydata/xarray/issues/7680 IC_kwDOAMm_X85YefCW jhamman 2443309 2023-03-27T02:23:15Z 2023-03-27T02:23:15Z MEMBER

@abunimeh - Thanks for opening this issue. Can you expand on the feature a bit more? What API would you like to see? ds.to_netcdf(..., track_order=False)?

I suspect this will need to be treated like invalid_netcdf as it will only apply to the h5netcdf backend:

https://github.com/pydata/xarray/blob/86f3f21ab3d0dff6fdb4a0bccd27c62f9e4a3238/xarray/core/dataset.py#L1892-L1895

_Note: it would be nice if we had backend_kwargs on to_netcdf since the variety of options scipy/netcdf4/h5netcdf support are increasingly different.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow track_order to be passed to h5netcdf 1641109066

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);