issue_comments

Table actions

4 rows where issue = 1618336774 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • [skip-ci] Fix groupby binary ops benchmarks · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1468702898 https://github.com/pydata/xarray/pull/7603#issuecomment-1468702898 https://api.github.com/repos/pydata/xarray/issues/7603 IC_kwDOAMm_X85XiqCy Illviljan 14371165 2023-03-14T19:27:51Z 2023-03-14T19:27:51Z MEMBER

Error: [ 89.17%] ··· groupby.ResampleDask.time_binary_op_1d failed Error: [ 89.17%] ···· Traceback (most recent call last): File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 1293, in main_run_server main_run(run_args) File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 1167, in main_run result = benchmark.do_run() File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 573, in do_run return self.run(*self._current_params) File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 669, in run samples, number = self.benchmark_timing(timer, min_repeat, max_repeat, File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 705, in benchmark_timing timing = timer.timeit(number) File "/home/runner/work/xarray/xarray/asv_bench/.asv/env/e3a5540da3d30da735a9fb168f264be6/lib/python3.10/timeit.py", line 178, in timeit timing = self.inner(it, self.timer) File "<timeit-src>", line 6, in inner File "/home/runner/work/xarray/xarray/asv_bench/benchmarks/groupby.py", line 127, in time_binary_op_1d raise NotImplementedError NotImplementedError asv: benchmark failed (exit status 1)

Comparing to https://github.com/pydata/xarray/blob/5043223ca7942c6eb582798aafa843d2efc0895b/asv_bench/benchmarks/init.py#L72-L74

It has to be initialized? Try adding a short description with why it's not implemented/link to issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [skip-ci] Fix groupby binary ops benchmarks 1618336774
1468695446 https://github.com/pydata/xarray/pull/7603#issuecomment-1468695446 https://api.github.com/repos/pydata/xarray/issues/7603 IC_kwDOAMm_X85XioOW dcherian 2448579 2023-03-14T19:21:04Z 2023-03-14T19:21:04Z MEMBER

Hmmm not sure why the resample binary ops benchmarks still fail.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [skip-ci] Fix groupby binary ops benchmarks 1618336774
1467288764 https://github.com/pydata/xarray/pull/7603#issuecomment-1467288764 https://api.github.com/repos/pydata/xarray/issues/7603 IC_kwDOAMm_X85XdQy8 dcherian 2448579 2023-03-14T03:15:04Z 2023-03-14T03:15:04Z MEMBER

No this is a real failure with no test coverage :(. I guess not many people do resampling binary ops?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [skip-ci] Fix groupby binary ops benchmarks 1618336774
1463319021 https://github.com/pydata/xarray/pull/7603#issuecomment-1463319021 https://api.github.com/repos/pydata/xarray/issues/7603 IC_kwDOAMm_X85XOHnt Illviljan 14371165 2023-03-10T06:03:20Z 2023-03-10T06:03:20Z MEMBER

Ahh, there are a few errors in the benchmarks. Are those fixed with your other PRs? Error: [ 88.75%] ··· ...by.ResampleDask.peakmem_groupby_binary_op_2d failed Error: [ 88.75%] ···· Traceback (most recent call last): File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 1293, in main_run_server main_run(run_args) File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 1167, in main_run result = benchmark.do_run() File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 573, in do_run return self.run(*self._current_params) File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 842, in run self.func(*param) File "/home/runner/work/xarray/xarray/asv_bench/benchmarks/groupby.py", line 136, in peakmem_groupby_binary_op_2d self.ds2d.resample(time="48H") - self.ds2d_mean File "/home/runner/work/xarray/xarray/asv_bench/.asv/env/e3a5540da3d30da735a9fb168f264be6/lib/python3.10/site-packages/xarray/core/_typed_ops.py", line 589, in __sub__ return self._binary_op(other, operator.sub) File "/home/runner/work/xarray/xarray/asv_bench/.asv/env/e3a5540da3d30da735a9fb168f264be6/lib/python3.10/site-packages/xarray/core/groupby.py", line 601, in _binary_op raise ValueError( ValueError: incompatible dimensions for a grouped binary operation: the group variable '__resample_dim__' is not a dimension on the other argument asv: benchmark failed (exit status 1)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [skip-ci] Fix groupby binary ops benchmarks 1618336774

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);