issue_comments: 1463319021

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7603#issuecomment-1463319021 https://api.github.com/repos/pydata/xarray/issues/7603 1463319021 IC_kwDOAMm_X85XOHnt 14371165 2023-03-10T06:03:20Z 2023-03-10T06:03:20Z MEMBER

Ahh, there are a few errors in the benchmarks. Are those fixed with your other PRs? Error: [ 88.75%] ··· ...by.ResampleDask.peakmem_groupby_binary_op_2d failed Error: [ 88.75%] ···· Traceback (most recent call last): File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 1293, in main_run_server main_run(run_args) File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 1167, in main_run result = benchmark.do_run() File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 573, in do_run return self.run(*self._current_params) File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/site-packages/asv/benchmark.py", line 842, in run self.func(*param) File "/home/runner/work/xarray/xarray/asv_bench/benchmarks/groupby.py", line 136, in peakmem_groupby_binary_op_2d self.ds2d.resample(time="48H") - self.ds2d_mean File "/home/runner/work/xarray/xarray/asv_bench/.asv/env/e3a5540da3d30da735a9fb168f264be6/lib/python3.10/site-packages/xarray/core/_typed_ops.py", line 589, in __sub__ return self._binary_op(other, operator.sub) File "/home/runner/work/xarray/xarray/asv_bench/.asv/env/e3a5540da3d30da735a9fb168f264be6/lib/python3.10/site-packages/xarray/core/groupby.py", line 601, in _binary_op raise ValueError( ValueError: incompatible dimensions for a grouped binary operation: the group variable '__resample_dim__' is not a dimension on the other argument asv: benchmark failed (exit status 1)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1618336774