issue_comments

Table actions

3 rows where issue = 160466764 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • ENH: Allow ds selection with callable? · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
236985767 https://github.com/pydata/xarray/issues/883#issuecomment-236985767 https://api.github.com/repos/pydata/xarray/issues/883 MDEyOklzc3VlQ29tbWVudDIzNjk4NTc2Nw== max-sixty 5635139 2016-08-02T17:51:43Z 2016-08-02T17:51:43Z MEMBER

That makes sense. I'll close this and we can move to #916.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Allow ds selection with callable? 160466764
236984734 https://github.com/pydata/xarray/issues/883#issuecomment-236984734 https://api.github.com/repos/pydata/xarray/issues/883 MDEyOklzc3VlQ29tbWVudDIzNjk4NDczNA== shoyer 1217238 2016-08-02T17:48:32Z 2016-08-02T17:48:32Z MEMBER

I would slightly rather put this in a generic select or filter method (xref https://github.com/pydata/xarray/issues/916) than overload indexing further. Mostly, I am concerned that this is slightly different from the way pandas handles callables in indexing, which is to apply the callable to the object being indexed.

I'm thinking a signature something like Dataset.filter(func=None, like=None, regex=None) (see here for how filter is implemented in pandas). This does have the downside that it departs from pandas syntax by combining filter and select, but these are very related ways of filtering a dataset so it seems better to keep them in one method.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Allow ds selection with callable? 160466764
226253801 https://github.com/pydata/xarray/issues/883#issuecomment-226253801 https://api.github.com/repos/pydata/xarray/issues/883 MDEyOklzc3VlQ29tbWVudDIyNjI1MzgwMQ== shoyer 1217238 2016-06-15T17:08:29Z 2016-06-15T17:08:35Z MEMBER

There are possibly a few issues to work through here, but I like the look of it!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: Allow ds selection with callable? 160466764

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);