issue_comments: 236984734

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/883#issuecomment-236984734 https://api.github.com/repos/pydata/xarray/issues/883 236984734 MDEyOklzc3VlQ29tbWVudDIzNjk4NDczNA== 1217238 2016-08-02T17:48:32Z 2016-08-02T17:48:32Z MEMBER

I would slightly rather put this in a generic select or filter method (xref https://github.com/pydata/xarray/issues/916) than overload indexing further. Mostly, I am concerned that this is slightly different from the way pandas handles callables in indexing, which is to apply the callable to the object being indexed.

I'm thinking a signature something like Dataset.filter(func=None, like=None, regex=None) (see here for how filter is implemented in pandas). This does have the downside that it departs from pandas syntax by combining filter and select, but these are very related ways of filtering a dataset so it seems better to keep them in one method.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   160466764