issue_comments

Table actions

2 rows where issue = 157545837 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • decode_cf not concatenating string arrays · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
224920993 https://github.com/pydata/xarray/issues/862#issuecomment-224920993 https://api.github.com/repos/pydata/xarray/issues/862 MDEyOklzc3VlQ29tbWVudDIyNDkyMDk5Mw== shoyer 1217238 2016-06-09T14:55:24Z 2016-06-09T14:55:24Z MEMBER

first check if decode_cf is working on a Dataset or AbstractDataStore (e: which it already does anyway), and then decide whether to concatenate over a dimension or not

This seems a little too magical to me. How would we know if the dataset dimension was added intentionally or not?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decode_cf not concatenating string arrays 157545837
222873438 https://github.com/pydata/xarray/issues/862#issuecomment-222873438 https://api.github.com/repos/pydata/xarray/issues/862 MDEyOklzc3VlQ29tbWVudDIyMjg3MzQzOA== shoyer 1217238 2016-06-01T02:05:42Z 2016-06-01T02:05:42Z MEMBER

The heuristic we use for determining if you can concatenate over a dimension includes checking if it's included as a variable: https://github.com/pydata/xarray/blob/v0.7.2/xarray/conventions.py#L800

If a potential dummy dimension is also a variable, we don't concatenate over it.

Of course, every dimension gets a variable by the time you've turned it into a dataset, so this never works on datasets, only data stores.

I'm certainly open to ideas on how to improve this. Possibly accepting an explicit lists of dimensions to concatenate over (and remove) would be the way to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   decode_cf not concatenating string arrays 157545837

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);