home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 222873438

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/862#issuecomment-222873438 https://api.github.com/repos/pydata/xarray/issues/862 222873438 MDEyOklzc3VlQ29tbWVudDIyMjg3MzQzOA== 1217238 2016-06-01T02:05:42Z 2016-06-01T02:05:42Z MEMBER

The heuristic we use for determining if you can concatenate over a dimension includes checking if it's included as a variable: https://github.com/pydata/xarray/blob/v0.7.2/xarray/conventions.py#L800

If a potential dummy dimension is also a variable, we don't concatenate over it.

Of course, every dimension gets a variable by the time you've turned it into a dataset, so this never works on datasets, only data stores.

I'm certainly open to ideas on how to improve this. Possibly accepting an explicit lists of dimensions to concatenate over (and remove) would be the way to go.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  157545837
Powered by Datasette · Queries took 0.733ms · About: xarray-datasette