issue_comments

Table actions

7 rows where issue = 156591025 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • BUG: Rolling on Dataset · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
281439633 https://github.com/pydata/xarray/issues/859#issuecomment-281439633 https://api.github.com/repos/pydata/xarray/issues/859 MDEyOklzc3VlQ29tbWVudDI4MTQzOTYzMw== max-sixty 5635139 2017-02-21T18:50:49Z 2017-02-21T18:50:49Z MEMBER

Did this ever get fixed?

Not fixed yet, but PRs welcome

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Rolling on Dataset 156591025
281419575 https://github.com/pydata/xarray/issues/859#issuecomment-281419575 https://api.github.com/repos/pydata/xarray/issues/859 MDEyOklzc3VlQ29tbWVudDI4MTQxOTU3NQ== tdennist 7513340 2017-02-21T17:42:12Z 2017-02-21T17:42:12Z NONE

Did this ever get fixed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Rolling on Dataset 156591025
271536552 https://github.com/pydata/xarray/issues/859#issuecomment-271536552 https://api.github.com/repos/pydata/xarray/issues/859 MDEyOklzc3VlQ29tbWVudDI3MTUzNjU1Mg== fmaussion 10050469 2017-01-10T10:11:58Z 2017-01-10T10:11:58Z MEMBER

This just happened to me too:

```python In [1]: import xarray as xr In [2]: ds = xr.open_dataset('ERA-Int-Monthly-UVSLP.nc') In [3]: ds = ds.rolling()

AttributeError Traceback (most recent call last) <ipython-input-3-16ff572cfc35> in <module>() ----> 1 ds = ds.rolling()

/home/mowglie/Documents/git/xarray/xarray/core/common.py in rolling(self, min_periods, center, windows) 507 """ 508 --> 509 return self.rolling_cls(self, min_periods=min_periods, 510 center=center, windows) 511

/home/mowglie/Documents/git/xarray/xarray/core/common.py in getattr(self, name) 224 return source[name] 225 raise AttributeError("%r object has no attribute %r" % --> 226 (type(self).name, name)) 227 228 def setattr(self, name, value):

AttributeError: 'Dataset' object has no attribute 'rolling_cls' ```

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Rolling on Dataset 156591025
221445932 https://github.com/pydata/xarray/issues/859#issuecomment-221445932 https://api.github.com/repos/pydata/xarray/issues/859 MDEyOklzc3VlQ29tbWVudDIyMTQ0NTkzMg== shoyer 1217238 2016-05-25T01:01:17Z 2016-05-25T01:01:17Z MEMBER

I think this could be easy to implement as an .apply operation? (indeed, that could be a reasonable path for a whole host of operations - i.e. try and apply them to each array in the ds?)

Agreed, this should be pretty easy!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Rolling on Dataset 156591025
221402816 https://github.com/pydata/xarray/issues/859#issuecomment-221402816 https://api.github.com/repos/pydata/xarray/issues/859 MDEyOklzc3VlQ29tbWVudDIyMTQwMjgxNg== max-sixty 5635139 2016-05-24T21:12:25Z 2016-05-24T21:12:25Z MEMBER

I just matched the implementation of groupby_cls.

Right, that should be private too

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Rolling on Dataset 156591025
221392885 https://github.com/pydata/xarray/issues/859#issuecomment-221392885 https://api.github.com/repos/pydata/xarray/issues/859 MDEyOklzc3VlQ29tbWVudDIyMTM5Mjg4NQ== jhamman 2443309 2016-05-24T20:33:45Z 2016-05-24T20:33:45Z MEMBER

@MaximilianR - nice catch. I originally implemented the rolling method in BaseDataObject intending to scale this up to the dataset. Time ran out and my immediate application didn't need a dataset version of the method but I never moved it out of the BaseDataObject.

As you mentioned, I don't think it will be difficult to build a rolling method for the Dataset.

As for the public/private point, I'm not sure what to say. I just matched the implementation of groupby_cls.

Glad you're enjoying the rolling method!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Rolling on Dataset 156591025
221378851 https://github.com/pydata/xarray/issues/859#issuecomment-221378851 https://api.github.com/repos/pydata/xarray/issues/859 MDEyOklzc3VlQ29tbWVudDIyMTM3ODg1MQ== max-sixty 5635139 2016-05-24T19:35:41Z 2016-05-24T19:35:41Z MEMBER

CC @jhamman 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Rolling on Dataset 156591025

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);