issue_comments: 221392885

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/859#issuecomment-221392885 https://api.github.com/repos/pydata/xarray/issues/859 221392885 MDEyOklzc3VlQ29tbWVudDIyMTM5Mjg4NQ== 2443309 2016-05-24T20:33:45Z 2016-05-24T20:33:45Z MEMBER

@MaximilianR - nice catch. I originally implemented the rolling method in BaseDataObject intending to scale this up to the dataset. Time ran out and my immediate application didn't need a dataset version of the method but I never moved it out of the BaseDataObject.

As you mentioned, I don't think it will be difficult to build a rolling method for the Dataset.

As for the public/private point, I'm not sure what to say. I just matched the implementation of groupby_cls.

Glad you're enjoying the rolling method!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   156591025