issue_comments

Table actions

8 rows where issue = 152888663 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fix #665 decode_cf_timedelta 2D · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
219189433 https://github.com/pydata/xarray/pull/842#issuecomment-219189433 https://api.github.com/repos/pydata/xarray/issues/842 MDEyOklzc3VlQ29tbWVudDIxOTE4OTQzMw== ocefpaf 950575 2016-05-14T00:36:12Z 2016-05-14T00:36:12Z CONTRIBUTOR

Sorry, I'm going camping this weekend so I won't be able to get this out. Next time give me just a little bit more warning :).

No biggie. As I mentioned above I have a plan B (conda install of the latest dev version).

Enjoy your camping!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #665 decode_cf_timedelta 2D 152888663
219189318 https://github.com/pydata/xarray/pull/842#issuecomment-219189318 https://api.github.com/repos/pydata/xarray/issues/842 MDEyOklzc3VlQ29tbWVudDIxOTE4OTMxOA== shoyer 1217238 2016-05-14T00:34:54Z 2016-05-14T00:34:54Z MEMBER

Sorry, I'm going camping this weekend so I won't be able to get this out. Next time give me just a little bit more warning :). On Fri, May 13, 2016 at 8:15 AM Filipe notifications@github.com wrote:

@shoyer https://github.com/shoyer I will be teaching a tutorial next Monday that will hit this bug. I know it is a lot to ask... But do you think you could cut a bugfix release? (I have a plan B https://github.com/ioos/conda-recipes/pull/844/files be already, so no pressure.)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/pydata/xarray/pull/842#issuecomment-219073332

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #665 decode_cf_timedelta 2D 152888663
219073332 https://github.com/pydata/xarray/pull/842#issuecomment-219073332 https://api.github.com/repos/pydata/xarray/issues/842 MDEyOklzc3VlQ29tbWVudDIxOTA3MzMzMg== ocefpaf 950575 2016-05-13T15:15:39Z 2016-05-13T15:15:39Z CONTRIBUTOR

@shoyer I will be teaching a tutorial next Monday that will hit this bug. I know it is a lot to ask... But do you think you could cut a bugfix release? (I have a plan B be already, so no pressure.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #665 decode_cf_timedelta 2D 152888663
216935322 https://github.com/pydata/xarray/pull/842#issuecomment-216935322 https://api.github.com/repos/pydata/xarray/issues/842 MDEyOklzc3VlQ29tbWVudDIxNjkzNTMyMg== shoyer 1217238 2016-05-04T17:12:09Z 2016-05-04T17:12:09Z MEMBER

Thanks @ocefpaf !

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #665 decode_cf_timedelta 2D 152888663
216934289 https://github.com/pydata/xarray/pull/842#issuecomment-216934289 https://api.github.com/repos/pydata/xarray/issues/842 MDEyOklzc3VlQ29tbWVudDIxNjkzNDI4OQ== ocefpaf 950575 2016-05-04T17:08:19Z 2016-05-04T17:08:19Z CONTRIBUTOR

possibly we should add an explicit toggle for decoding timedeltas vs datetimes.

:+1:

I am opening a separated issue for that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #665 decode_cf_timedelta 2D 152888663
216933269 https://github.com/pydata/xarray/pull/842#issuecomment-216933269 https://api.github.com/repos/pydata/xarray/issues/842 MDEyOklzc3VlQ29tbWVudDIxNjkzMzI2OQ== shoyer 1217238 2016-05-04T17:04:47Z 2016-05-04T17:04:47Z MEMBER

I agree that decoding time units to timedeltas is not always desirable -- possibly we should add an explicit toggle for decoding timedeltas vs datetimes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #665 decode_cf_timedelta 2D 152888663
216931822 https://github.com/pydata/xarray/pull/842#issuecomment-216931822 https://api.github.com/repos/pydata/xarray/issues/842 MDEyOklzc3VlQ29tbWVudDIxNjkzMTgyMg== ocefpaf 950575 2016-05-04T16:59:40Z 2016-05-04T16:59:40Z CONTRIBUTOR

Looks great! Please add a brief bug fix note to "What's new", then I will merge.

How about https://github.com/pydata/xarray/pull/842/commits/518ea53284f659edbb31cd98c326b3e78f440fc3?

PS: @shoyer I am still not sure that converting any data that has units of time to timedelta is desirable as the default behavior. I may be biased but in my datasets (waves period data) we usually do not want that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #665 decode_cf_timedelta 2D 152888663
216923304 https://github.com/pydata/xarray/pull/842#issuecomment-216923304 https://api.github.com/repos/pydata/xarray/issues/842 MDEyOklzc3VlQ29tbWVudDIxNjkyMzMwNA== shoyer 1217238 2016-05-04T16:38:48Z 2016-05-04T16:38:48Z MEMBER

Looks great! Please add a brief bug fix note to "What's new", then I will merge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #665 decode_cf_timedelta 2D 152888663

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);