home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 216931822

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/842#issuecomment-216931822 https://api.github.com/repos/pydata/xarray/issues/842 216931822 MDEyOklzc3VlQ29tbWVudDIxNjkzMTgyMg== 950575 2016-05-04T16:59:40Z 2016-05-04T16:59:40Z CONTRIBUTOR

Looks great! Please add a brief bug fix note to "What's new", then I will merge.

How about https://github.com/pydata/xarray/pull/842/commits/518ea53284f659edbb31cd98c326b3e78f440fc3?

PS: @shoyer I am still not sure that converting any data that has units of time to timedelta is desirable as the default behavior. I may be biased but in my datasets (waves period data) we usually do not want that.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  152888663
Powered by Datasette · Queries took 0.437ms · About: xarray-datasette