issue_comments

Table actions

2 rows where issue = 1521368478 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • unstacking an integer array yields a RuntimeWarning after upgrade to numpy 1.24.1 · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1453395303 https://github.com/pydata/xarray/issues/7423#issuecomment-1453395303 https://api.github.com/repos/pydata/xarray/issues/7423 IC_kwDOAMm_X85WoQ1n keewis 14808389 2023-03-03T11:35:33Z 2023-03-03T15:42:01Z MEMBER

I just encountered this one as well. It seems the issue is here: https://github.com/pydata/xarray/blob/43ba095712de12c957e0a4acf956df01d84b2046/xarray/core/variable.py#L1815-L1820 where fill_value = np.nan and dtype = "int64".

As mentioned in https://github.com/numpy/numpy/issues/8017#issuecomment-1155517077, numpy now warns instead of silently casting nan to int.

Can we do anything about that here (besides silencing the warning, but I'm not sure if that actually makes sense), or do we need to lobby for nullable dtypes in numpy or a numpy-adjacent library?

Edit: as it seems there are at least 4 deferred NEPs (NEPs 12, 24, 25, and 26) on the topic of missing values this might be more tricky than I expected. So I guess that means that we might have to try finding a workaround.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   unstacking an integer array yields a RuntimeWarning after upgrade to numpy 1.24.1 1521368478
1453707146 https://github.com/pydata/xarray/issues/7423#issuecomment-1453707146 https://api.github.com/repos/pydata/xarray/issues/7423 IC_kwDOAMm_X85Wpc-K itcarroll 3383837 2023-03-03T15:33:27Z 2023-03-03T15:33:27Z CONTRIBUTOR

Would you consider xarray itself to be "numpy-adjacent"? If XArray fully adopted (i don't know how!) the NetCDF4 _FillValue attribute, this and some other challenges, could be solved rigorously.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   unstacking an integer array yields a RuntimeWarning after upgrade to numpy 1.24.1 1521368478

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);