home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1453395303

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/7423#issuecomment-1453395303 https://api.github.com/repos/pydata/xarray/issues/7423 1453395303 IC_kwDOAMm_X85WoQ1n 14808389 2023-03-03T11:35:33Z 2023-03-03T15:42:01Z MEMBER

I just encountered this one as well. It seems the issue is here: https://github.com/pydata/xarray/blob/43ba095712de12c957e0a4acf956df01d84b2046/xarray/core/variable.py#L1815-L1820 where fill_value = np.nan and dtype = "int64".

As mentioned in https://github.com/numpy/numpy/issues/8017#issuecomment-1155517077, numpy now warns instead of silently casting nan to int.

Can we do anything about that here (besides silencing the warning, but I'm not sure if that actually makes sense), or do we need to lobby for nullable dtypes in numpy or a numpy-adjacent library?

Edit: as it seems there are at least 4 deferred NEPs (NEPs 12, 24, 25, and 26) on the topic of missing values this might be more tricky than I expected. So I guess that means that we might have to try finding a workaround.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1521368478
Powered by Datasette · Queries took 0.688ms · About: xarray-datasette