issue_comments

Table actions

5 rows where issue = 1519058102 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • install `numbagg` from `conda-forge` · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1384016578 https://github.com/pydata/xarray/pull/7415#issuecomment-1384016578 https://api.github.com/repos/pydata/xarray/issues/7415 IC_kwDOAMm_X85SfmrC keewis 14808389 2023-01-16T12:56:25Z 2023-01-16T12:59:22Z MEMBER

do we need to worry about this: pytb Traceback (most recent call last): File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/doctest.py", line 1350, in __run exec(compile(example.source, filename, "single", File "<doctest xarray.core.rolling_exp.RollingExp.sum[1]>", line 1, in <module> File "/home/runner/work/xarray/xarray/xarray/core/rolling_exp.py", line 162, in sum return self.obj.reduce( File "/home/runner/work/xarray/xarray/xarray/core/dataarray.py", line 3667, in reduce var = self.variable.reduce(func, dim, axis, keep_attrs, keepdims, **kwargs) File "/home/runner/work/xarray/xarray/xarray/core/variable.py", line 1955, in reduce data = func(self.data, axis=axis, **kwargs) File "/home/runner/work/xarray/xarray/xarray/core/rolling_exp.py", line 41, in move_exp_nansum raise ValueError("`rolling_exp(...).sum() requires numbagg>=0.2.1.") ValueError: `rolling_exp(...).sum() requires numbagg>=0.2.1. not being caught by CI?

Edit: to answer my own question: no, because most of the the rolling_exp tests are explicitly skipped if the numbagg version is too old

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   install `numbagg` from `conda-forge` 1519058102
1371344257 https://github.com/pydata/xarray/pull/7415#issuecomment-1371344257 https://api.github.com/repos/pydata/xarray/issues/7415 IC_kwDOAMm_X85RvQ2B max-sixty 5635139 2023-01-04T19:42:56Z 2023-01-04T19:42:56Z MEMBER

This has even been fixed since then, but not released. @max-sixty, would it be possible to issue a new release?

This should now be releasing! https://github.com/numbagg/numbagg/releases/tag/v0.2.2

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 2,
    "rocket": 0,
    "eyes": 0
}
   install `numbagg` from `conda-forge` 1519058102
1371035994 https://github.com/pydata/xarray/pull/7415#issuecomment-1371035994 https://api.github.com/repos/pydata/xarray/issues/7415 IC_kwDOAMm_X85RuFla keewis 14808389 2023-01-04T14:59:28Z 2023-01-04T14:59:46Z MEMBER

ah, that makes sense, thanks. I must have missed that line while checking the package metadata. This has even been fixed since then, but not released. @max-sixty, would it be possible to issue a new release?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   install `numbagg` from `conda-forge` 1519058102
1371028352 https://github.com/pydata/xarray/pull/7415#issuecomment-1371028352 https://api.github.com/repos/pydata/xarray/issues/7415 IC_kwDOAMm_X85RuDuA ocefpaf 950575 2023-01-04T14:53:15Z 2023-01-04T14:53:15Z CONTRIBUTOR

that looks like it works, besides the fact that conda reports numbagg=0.2.1 but

It is not a conda problem but a bug upstream. The v0.2.1 tag hasv0.2.0 hardcoded in it.

See https://github.com/numbagg/numbagg/blob/v0.2.1/setup.py#L24

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   install `numbagg` from `conda-forge` 1519058102
1371019131 https://github.com/pydata/xarray/pull/7415#issuecomment-1371019131 https://api.github.com/repos/pydata/xarray/issues/7415 IC_kwDOAMm_X85RuBd7 keewis 14808389 2023-01-04T14:45:28Z 2023-01-04T14:45:28Z MEMBER

that looks like it works, besides the fact that conda reports numbagg=0.2.1 but python print(f"numbagg={numbagg.__version__}") prints numbagg=0.2.0 (cc @ocefpaf)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   install `numbagg` from `conda-forge` 1519058102

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);