issue_comments: 1384016578

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7415#issuecomment-1384016578 https://api.github.com/repos/pydata/xarray/issues/7415 1384016578 IC_kwDOAMm_X85SfmrC 14808389 2023-01-16T12:56:25Z 2023-01-16T12:59:22Z MEMBER

do we need to worry about this: pytb Traceback (most recent call last): File "/home/runner/micromamba-root/envs/xarray-tests/lib/python3.10/doctest.py", line 1350, in __run exec(compile(example.source, filename, "single", File "<doctest xarray.core.rolling_exp.RollingExp.sum[1]>", line 1, in <module> File "/home/runner/work/xarray/xarray/xarray/core/rolling_exp.py", line 162, in sum return self.obj.reduce( File "/home/runner/work/xarray/xarray/xarray/core/dataarray.py", line 3667, in reduce var = self.variable.reduce(func, dim, axis, keep_attrs, keepdims, **kwargs) File "/home/runner/work/xarray/xarray/xarray/core/variable.py", line 1955, in reduce data = func(self.data, axis=axis, **kwargs) File "/home/runner/work/xarray/xarray/xarray/core/rolling_exp.py", line 41, in move_exp_nansum raise ValueError("`rolling_exp(...).sum() requires numbagg>=0.2.1.") ValueError: `rolling_exp(...).sum() requires numbagg>=0.2.1. not being caught by CI?

Edit: to answer my own question: no, because most of the the rolling_exp tests are explicitly skipped if the numbagg version is too old

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1519058102