issue_comments: 1345679164

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7361#issuecomment-1345679164 https://api.github.com/repos/pydata/xarray/issues/7361 1345679164 IC_kwDOAMm_X85QNW88 6628425 2022-12-11T22:50:57Z 2022-12-11T22:50:57Z MEMBER

Technically I think we would consider get_loc to be public (both due to how it is named and in that it is at least primitively documented). That said, I don't know how many people use the lower level methods of CFTimeIndexes like get_loc outside of xarray data structures.

My inclination is that it would not require a deprecation cycle, given the warning had already been being raised as in the example above. It's true though that this warning was not being emitted in the case that key was a string, so perhaps it's a little borderline. Maybe @dcherian or @mathause, do you have any thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1477931237