issue_comments

@patrick-naylor, feel free to try out a better default example if you want.

@keewis What does the numbers mean in Cannot parse: 201:27? Because I can't find any functions with docstrings in this file, it's just a bunch of multiline strings that are defined to variables and in my mind shouldn't trigger blackdoc.

@dcherian cumsum for resample fails for some reason do you have any ideas?

```python import numpy as np import pandas as pd import xarray as xr da = xr.DataArray( np.array([1, 2, 3, 1, 2, np.nan]), dims="time", coords=dict( time=("time", pd.date_range("01-01-2001", freq="M", periods=6)), labels=("time", np.array(["a", "b", "c", "c", "b", "a"])), ), ) ds = xr.Dataset(dict(da=da)) a = ds.resample(time="3M") a.cumsum()

Traceback (most recent call last):

File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\spyder_kernels\py3compat.py", line 356, in compat_exec exec(code, globals, locals)

File "c:\users\j.w\documents\github\xarray\xarray\util\untitled2.py", line 20, in <module> a.cumsum()

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\core_aggregations.py", line 4921, in cumsum return self.reduce(

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\core\resample.py", line 395, in reduce return super().reduce(

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\core\groupby.py", line 1357, in reduce return self.map(reduce_dataset)

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\core\resample.py", line 342, in map return combined.rename({self._resample_dim: self._dim})

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\core\dataset.py", line 3646, in rename return self._rename(name_dict=name_dict, **names)

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\core\dataset.py", line 3587, in _rename raise ValueError(

ValueError: cannot rename 'resample_dim' because it is not a variable or dimension in this dataset ```

@keewis do you understand this blackdoc error?

``` trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed debug statements (python)................................................Passed mixed line ending........................................................Passed autoflake................................................................Passed isort....................................................................Passed pyupgrade................................................................Passed black....................................................................Passed black-jupyter............................................................Passed blackdoc.................................................................Failed - hook id: blackdoc - exit code: 123

error: cannot format /code/xarray/util/generate_aggregations.py: Cannot parse: 201:27: EOF in multi-line string Oh no! 💥 💔 💥 215 files left unchanged, 1 file fails to reformat. ```

I don't think you have flox installed, if it's not installed the code will take the old path. Do conda install flox and I think you'll get the NotImplementedError. Then you maybe have to change the default settings in cumsum so flox is not used.

Right now, I think cumsum and cumprod is enough. numpy-groupies has a few more examples that I suppose we could support in the future.

Very nice, this is something that's been on the TODO list! :)

I believe we wanted to rename generate_reductions.py to generate_aggregations.py so cumsum et al could be included and generated there as well. Is there a lot of work for you if try to merge these into that one?