issue_comments

Table actions

8 rows where issue = 138086327 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • dont infer interval breaks in pcolormesh when ax is a cartopy axis · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
195492662 https://github.com/pydata/xarray/pull/782#issuecomment-195492662 https://api.github.com/repos/pydata/xarray/issues/782 MDEyOklzc3VlQ29tbWVudDE5NTQ5MjY2Mg== shoyer 1217238 2016-03-11T18:40:56Z 2016-03-11T18:40:56Z MEMBER

Works for me

On Fri, Mar 11, 2016 at 10:40 AM, Joe Hamman notifications@github.com wrote:

So do we want to remove _infer_interval_breaks all together in this PR? I'm leaning toward merging this as is and following up with another PR to handle the unevenly spaced coordinates in the future.

— Reply to this email directly or view it on GitHub https://github.com/pydata/xarray/pull/782#issuecomment-195492398.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dont infer interval breaks in pcolormesh when ax is a cartopy axis 138086327
195492398 https://github.com/pydata/xarray/pull/782#issuecomment-195492398 https://api.github.com/repos/pydata/xarray/issues/782 MDEyOklzc3VlQ29tbWVudDE5NTQ5MjM5OA== jhamman 2443309 2016-03-11T18:40:03Z 2016-03-11T18:40:03Z MEMBER

So do we want to remove _infer_interval_breaks all together in this PR? I'm leaning toward merging this as is and following up with another PR to handle the unevenly spaced coordinates in the future.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dont infer interval breaks in pcolormesh when ax is a cartopy axis 138086327
195455648 https://github.com/pydata/xarray/pull/782#issuecomment-195455648 https://api.github.com/repos/pydata/xarray/issues/782 MDEyOklzc3VlQ29tbWVudDE5NTQ1NTY0OA== shoyer 1217238 2016-03-11T17:03:41Z 2016-03-11T17:03:41Z MEMBER

This PR looks good to me.

Regarding the larger issue of not inferring bounds, I guess I would be on board with that change, too. The original idea was to make pcolormesh and imshow consistent (other than the underlying plotting engine) and to always plot that last row/column of data, but maybe it's better to force users to be explicit. At the very least, it is clearly a bad idea to adjust bounds if they are not equally spaced (but I agree that guessing is bad default behavior).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dont infer interval breaks in pcolormesh when ax is a cartopy axis 138086327
195066916 https://github.com/pydata/xarray/pull/782#issuecomment-195066916 https://api.github.com/repos/pydata/xarray/issues/782 MDEyOklzc3VlQ29tbWVudDE5NTA2NjkxNg== jhamman 2443309 2016-03-10T21:51:08Z 2016-03-10T21:51:08Z MEMBER

any more comments here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dont infer interval breaks in pcolormesh when ax is a cartopy axis 138086327
192037109 https://github.com/pydata/xarray/pull/782#issuecomment-192037109 https://api.github.com/repos/pydata/xarray/issues/782 MDEyOklzc3VlQ29tbWVudDE5MjAzNzEwOQ== jhamman 2443309 2016-03-04T00:38:12Z 2016-03-04T00:38:12Z MEMBER

Short of adding cartopy to our continuous integration setup, does anyone have any ideas on how to test this change more robustly than I have shown here? I want to avoid testing the behavior of the either matplotlib or Cartopy and since in this case, we're choosing not to modify their behavior, I'm not sure we need to test further.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dont infer interval breaks in pcolormesh when ax is a cartopy axis 138086327
191840829 https://github.com/pydata/xarray/pull/782#issuecomment-191840829 https://api.github.com/repos/pydata/xarray/issues/782 MDEyOklzc3VlQ29tbWVudDE5MTg0MDgyOQ== ocefpaf 950575 2016-03-03T16:32:20Z 2016-03-03T16:33:54Z CONTRIBUTOR

What if there are bounds in the file and the data is regularly spaced? I consider the current behavior a guess, and guessing should be an active user choice, not the automatic behavior. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dont infer interval breaks in pcolormesh when ax is a cartopy axis 138086327
191835686 https://github.com/pydata/xarray/pull/782#issuecomment-191835686 https://api.github.com/repos/pydata/xarray/issues/782 MDEyOklzc3VlQ29tbWVudDE5MTgzNTY4Ng== jhamman 2443309 2016-03-03T16:21:38Z 2016-03-03T16:21:38Z MEMBER

BTW I'd rather not have the _infer_interval_breaks at all.

Me too, but I don't mind doing it when we're not projecting the data.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dont infer interval breaks in pcolormesh when ax is a cartopy axis 138086327
191607244 https://github.com/pydata/xarray/pull/782#issuecomment-191607244 https://api.github.com/repos/pydata/xarray/issues/782 MDEyOklzc3VlQ29tbWVudDE5MTYwNzI0NA== ocefpaf 950575 2016-03-03T06:35:02Z 2016-03-03T06:35:02Z CONTRIBUTOR

Bare in mind that some netCDF4 files do have the bounds data and those should be used as "breaks" when available.

BTW I'd rather not have the _infer_interval_breaks at all, not sure if assuming linear at the mid points are generic enough.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dont infer interval breaks in pcolormesh when ax is a cartopy axis 138086327

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);