home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 195455648

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/782#issuecomment-195455648 https://api.github.com/repos/pydata/xarray/issues/782 195455648 MDEyOklzc3VlQ29tbWVudDE5NTQ1NTY0OA== 1217238 2016-03-11T17:03:41Z 2016-03-11T17:03:41Z MEMBER

This PR looks good to me.

Regarding the larger issue of not inferring bounds, I guess I would be on board with that change, too. The original idea was to make pcolormesh and imshow consistent (other than the underlying plotting engine) and to always plot that last row/column of data, but maybe it's better to force users to be explicit. At the very least, it is clearly a bad idea to adjust bounds if they are not equally spaced (but I agree that guessing is bad default behavior).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  138086327
Powered by Datasette · Queries took 1.131ms · About: xarray-datasette