issue_comments

Table actions

3 rows where issue = 1359451944 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Remove unnecessary build dependencies, use build defaults, strict twine check · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1242622466 https://github.com/pydata/xarray/pull/6979#issuecomment-1242622466 https://api.github.com/repos/pydata/xarray/issues/6979 IC_kwDOAMm_X85KEOoC andersy005 13301940 2022-09-10T04:17:31Z 2022-09-10T04:17:31Z MEMBER

thank you for the clarification, @mwtoews 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove unnecessary build dependencies, use build defaults, strict twine check 1359451944
1242590184 https://github.com/pydata/xarray/pull/6979#issuecomment-1242590184 https://api.github.com/repos/pydata/xarray/issues/6979 IC_kwDOAMm_X85KEGvo mwtoews 895458 2022-09-10T01:37:43Z 2022-09-10T01:37:43Z CONTRIBUTOR

Could we keep check-manifest and add a proper check instead of removing it entirely? It's worth ensuring we are shipping everything and check-manifest would help catch missing files, etc...

My guess is that it hasn't been needed since #4519 when MANIFEST.in was cleaned up by @max-sixty. It hasn't been needed since #3714. Also, from the check-manifest docs here:

Note that setuptools_scm usually makes MANIFEST.in files obsolete. Having one is helpful only if you intend to build an sdist and then use that sdist to perform further builds, instead of building from a source checkout.

Is this relevant? From my laptop, check-manifest takes ~10 seconds to compute. What value does it bring to CI checking?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove unnecessary build dependencies, use build defaults, strict twine check 1359451944
1242203788 https://github.com/pydata/xarray/pull/6979#issuecomment-1242203788 https://api.github.com/repos/pydata/xarray/issues/6979 IC_kwDOAMm_X85KCoaM andersy005 13301940 2022-09-09T16:36:23Z 2022-09-09T16:38:01Z MEMBER

Remove check-manifest, since it isn't used

Could we keep check-manifest and add a proper check instead of removing it entirely? It's worth ensuring we are shipping everything and check-manifest would help catch missing files, etc...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove unnecessary build dependencies, use build defaults, strict twine check 1359451944

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);